execute 'apt-get update' block removed in 2.4.x

[jwmarshall]

The removal of the following block (last appeared in 2.3.10) has broken several cookbooks that rely on hooking this event in their recipes. I found out the hard way after installing a newer cookbook that depends on apt. I was able to fix the issue by pinning to 2.3.x in my environment, but its worth mentioning since many cookbook developers do not pin the cookbook versions in their metadata.

What was the reason for the removal?

# For other recipes to call to force an update
execute 'apt-get update' do
  command 'apt-get update'
  ignore_failure true
  only_if { apt_installed? }
  action :nothing
end

[tmatilai]

It seemed to be done in #77. It was actually released in v2.5.0. The earlier v2.4.0 should still be working fine.

The "debian" cookbook was also affected (reaktor/chef-debian#15). I just released a new version which pins down the dependency. The earlier requirement was indeed too optimistic, but even ~> 2.4 would not have been enough as this was not released as a major version.

[fnichol]

Confirmed here as well with version 2.5.0 (version 2.4.0 does work as usual).

I'm going to throw a crazy theory out there and guess that because the remaining execute[apt-get update] resource is assigned to a variable, it doesn't actually land in the resource collection (or at least not in the first phase).

If I have a chance I'll circle back to confirm or disprove this guess, but in the meantime I've pinned back to ~> 2.4.0 and continued on for the day 😄

[kisoku]

Hey guys could you take my PR for a test drive and see if it improves the situation ?

[tmatilai]

This should be fixed in v2.5.2.

[kisoku]

As tmailai said, this was fixed in 2.5.2. Closing this issue