fix breakage introduced in apt 2.5.0 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA. There are 1 commit author(s) whose commits are authored by a non GitHub-verified email address in this Pull Request. Chef will have to verify by hand that they have signed a Chef CLA. |
kisoku
referenced
this pull request
Aug 14, 2014
| e.run_action(:run) | ||
| end | ||
|
|
||
| # Run apt-get update to create the stamp file | ||
| execute 'apt-get-update (first run)' do | ||
| execute 'apt-get-update' do |
There was a problem hiding this comment.
After this change, the resource becomes:
# Run apt-get update to create the stamp file
execute 'apt-get-update' do
command 'apt-get update'
ignore_failure true
only_if { apt_installed? }
not_if { ::File.exists?('/var/lib/apt/periodic/update-success-stamp') }
endIf somebody notifies "execute[apt-get-update]" and the update-success-stamp file exists, should not be updated? Perhaps we need a third apt-get update resource, like previously, but with different names.
someara
pushed a commit
that referenced
this pull request
Aug 14, 2014
fix breakage introduced in apt 2.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here's a proposed fix for issue #84