Add provider for consul acls

[kamaradclimber]

This patch introduces acl provider for consul.
Most consul resources can injected as configuration file, acls however
have to interacted with through http api.
ConsulClient library exposes minimum helpers for such interaction.

This patch is based on the work of @InformatiQ

[codecov-io]

Current coverage is 64.12%

Merging #220 into master will increase coverage by +8.85% as of ea5dc9d

@@            master    #220   diff @@
======================================
  Files            6       7     +1
  Stmts          322     354    +32
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            178     227    +49
  Partial          0       0       
+ Missed         144     127    -17

Review entire Coverage Diff as of ea5dc9d

Powered by Codecov. Updated on successful CI builds.

[kamaradclimber]

@johnbellone is there anything I can improve to get this merged ?

[kamaradclimber]

@johnbellone could you give me some feedback on this change ?

[johnbellone]

@kamaradclimber Apologies for not looking at this sooner.

I am wondering if we should be using an existing Ruby library for the Consul HTTP client? There seem to be a few on Rubygems.org already.

[johnbellone]

I am also going to need more tests here. I took a look at the code and am a little wary of executing arbitrary ruby blocks. Could you please explain what you're trying to do there? Maybe we could work on refactoring it.

[kamaradclimber]

thanks for you feedback. We still use the pre1.0 version of this cookbook in my organisation so I relied on rspec to validate the patch (version 1.0 does not work on windows 2012R2 probably due to a chef bug)

I'll have a look at your comments in the next days.

[kamaradclimber]

I can answer about using them gem: @InformatiQ has done the PR against the diplomat gem (WeAreFarmGeek/diplomat#46) that contains the code.

since the diplomat PR needs to be improved, let's put this one on hold until we are able to directly use diplomat gem.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.