Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URL for UI package #253

Merged
merged 2 commits into from
Dec 11, 2015
Merged

Update URL for UI package #253

merged 2 commits into from
Dec 11, 2015

Conversation

bdclark
Copy link
Contributor

@bdclark bdclark commented Dec 11, 2015

A PR was recently merged to update the URL of the main Consul binary; this PR updates the consul_ui resource to default to the new URL.

@codecov-io
Copy link

Current coverage is 64.63%

Merging #253 into master will decrease coverage by -7.93% as of e47ecca

@@            master    #253   diff @@
======================================
  Files            6       6       
  Stmts          328     328       
  Branches         0       0       
  Methods          0       0       
======================================
- Hit            238     212    -26
  Partial          0       0       
- Missed          90     116    +26

Review entire Coverage Diff as of e47ecca

Powered by Codecov. Updated on successful CI builds.

johnbellone added a commit that referenced this pull request Dec 11, 2015
@johnbellone
Merge pull request #253 from bdclark/ui_binary_url
df04559 
Update URL for UI package
@johnbellone johnbellone merged commit df04559 into sous-chefs:master Dec 11, 2015
Ginja
Ginja reviewed Dec 11, 2015
View reviewed changes
libraries/consul_ui.rb
@@ -26,7 +26,7 @@ class ConsulUI < Chef::Resource

# @!attribute binary_url
# @return [String]
attribute(:binary_url, kind_of: String, default: 'https://releases.hashicorp.com/consul/%{version}/%{filename}.zip')
attribute(:binary_url, kind_of: String, default: 'https://releases.hashicorp.com/consul/%{version}/consul_%{filename}.zip')

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

@Ginja Ginja mentioned this pull request Dec 11, 2015
Closed
@bdclark
Copy link
Contributor Author

bdclark commented Dec 12, 2015

I believe @Ginja is right. I submitted this PR in the spirit of #250 already being merged... at the time #252 was still outstanding. Since each took a different approach to solving the URL issue, it looks like merging both may have broke the world.

@Ginja Ginja mentioned this pull request Dec 13, 2015
Merged
johnbellone added a commit that referenced this pull request Dec 15, 2015
@johnbellone
Merge pull request #256 from visioncritical/remove-selinux
eedc49d 
Fixes #242 & Reverts #253
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bdclark @codecov-io @jslusher @Ginja @johnbellone