Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis for selinux set to disabled #242

Closed
ronlipke opened this Issue Nov 24, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@ronlipke
Copy link

ronlipke commented Nov 24, 2015

What is the basis for setting selinux to disabled in this cookbook? I see it changed from permissive sometime between version 1.2.0 and 1.3.0.
We have some compliance restrictions that require selinux and was surprised to see it outright disabled here.
Thanks!

@mdavis7771

This comment has been minimized.

Copy link

mdavis7771 commented Nov 27, 2015

+1

Ginja added a commit to visioncritical/consul-cookbook that referenced this issue Nov 30, 2015

Added support for choosing selinux state
Using the selinux state attribute (from the selinux cookbook) to
specify what state selinux should be in. Also changed the default
state to 'permissive'. Addresses sous-chefs#242.
@agperson

This comment has been minimized.

Copy link

agperson commented Dec 7, 2015

But why is this cookbook managing SELinux? I'm confused as to why it is in this purview at all.

@mdavis7771

This comment has been minimized.

Copy link

mdavis7771 commented Dec 8, 2015

I agree with @agperson. As a security professional, having no documentation of this change and adding it to the run list could dramatically impact my security. SELinux should be managed be a separate wrapper cookbook.

@johnbellone

This comment has been minimized.

Copy link
Contributor

johnbellone commented Dec 8, 2015

@mdavis7771 It is a long story, but ultimately it is a relic from an incorrect generation of this cookbook about a year ago. I do not have a problem removing this cookbook touching SELinux at all.

@johnbellone

This comment has been minimized.

Copy link
Contributor

johnbellone commented Dec 8, 2015

I'll accept a PR here if either @mdavis7771 or @agperson is willing to do so. We'll need to increment the minor release.

@johnbellone johnbellone added this to the 1.4 milestone Dec 8, 2015

@mdavis7771

This comment has been minimized.

Copy link

mdavis7771 commented Dec 8, 2015

@johnbellone, Understood, I'll do a PR later this week.

Ginja added a commit to visioncritical/consul-cookbook that referenced this issue Dec 13, 2015

Fixes sous-chefs#242
Removed the management of selinux
@Ginja

This comment has been minimized.

Copy link
Collaborator

Ginja commented Dec 13, 2015

#256 should fulfill this.

johnbellone added a commit that referenced this issue Dec 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.