Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specification of shell for the consul user #349

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

jirkafajfr
Copy link

Hi,

following two commits are changing shell of the consul user to /bin/nologin (or its variations)

this configuration prevents consul from executing handler in consul watch with following error:

2016/09/20 21:33:02 [ERR] agent: Failed to invoke watch handler 'XYZ': exit status 1

This patch allows wrapper cookbook to specify shell explicitly while retaining "security" for people not using consul watch functionality.

@codecov-io
Copy link

Current coverage is 60.45% (diff: 100%)

No coverage report found for master at a43dc10.

Powered by Codecov. Last update a43dc10...379ca3b

@quulah
Copy link

quulah commented Sep 22, 2016

There's also the old issue #271. So the scripts checks seem to be broken too without the user's shell.

@johnbellone johnbellone merged commit 12aabe1 into sous-chefs:master Sep 27, 2016
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants