Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source defaults from init if found #103

Closed
wants to merge 7 commits into from
Closed

Source defaults from init if found #103

wants to merge 7 commits into from

Conversation

chrisroberts
Copy link

No description provided.

@kamaradclimber
Copy link

default.elasticsearch[:default_file][:scrub_limits_conf] should be true by default to avoid having a breaking change

@chrisroberts
Copy link
Author

@kamaradclimber 👍

@kamaradclimber
Copy link

this is fine with me

@maxim
Copy link

maxim commented Jul 18, 2013

Folks, when will this be merged? I have a broken production, it dies randomly, and looks like this is the reason (see gist: https://gist.github.com/maxim/26278d8bc31e1c8d905b). If it isn't ready to merge, is there a workaround?

@maxim
Copy link

maxim commented Jul 18, 2013

For anyone who needs to workaround this issue right now, before it's merged — follow this gist. It implies that you have a wrapper cookbook or that you can put additional cookbook in your runlist containing this fix.

https://gist.github.com/maxim/6032578

@karmi
Copy link
Contributor

karmi commented Aug 1, 2013

@maxim I'd be very surprised if limits would be responsible for the Unknown mlockall error 0 you're seeing -- much more probably, the system cannot lock memory (too weak virtual machine, permissions, ...). I suspect you'd hit problems coming from file limits later.

karmi pushed a commit that referenced this pull request Aug 1, 2013
karmi added a commit that referenced this pull request Aug 1, 2013
Refactoring the way we set limits on the system:

* Use separate file in `/etc/limits.d/`
* Run `ulimit` in the init script defensively

Related issues: #118, #109, #103
@karmi
Copy link
Contributor

karmi commented Aug 1, 2013

So, I've created a mashup of @chrisroberts and @ctrabolds versions, so now we have a sane approach to /etc/security/limits.* and run ulimit in the init script to be on the defensive. Thanks for writing and testing the code, @chrisroberts! Please let me know if this works as expected and has the same behaviour as your changes.

@karmi karmi closed this Aug 1, 2013
@maxim
Copy link

maxim commented Aug 1, 2013

@karmi saw your mention on IRC as well. I ran ES on a machine with this configuration for months without problems, and all I did was rebuild identical-config'ed machine with updated ES. As soon as I applied my workaround - the crashing issue was gone, and since then (15 days ago) it's been running perfectly.

I'm surprised that you say limits have nothing to do with it, since the docs for ulimit -l state:

The maximum number of bytes of memory that may be locked into RAM. In effect this limit is rounded down to the nearest multiple of the system page size. This limit affects mlock(2) and mlockall(2) and the mmap(2) MAP_LOCKED operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants