Replaces bash with file resource to adjust file descriptor limits via limits.d
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reading the recommendations found [here](http://asquera.de/opensource/2012/11/25/elasticsearch-pre-flight-checklist/#file-descriptors) I thought that it would be a good idea to use `limits.d` instead of hacking the `limits.conf` file directly. This way Chef handles the idempotency itself and we can drop the custom (and hard to read) `not_if` magic. The result is the following file: # cat /etc/security/limits.d/10-elasticsearch.conf elasticsearch - nofile 4000 elasticsearch - memlock unlimited Tested on Vagrant with Debian 6 by removing the two lines from `/etc/security/limits.conf` and restarting the machine. Calling `ulimit -Hn` showed the expected value.
|
#103 does this as well but uses a source'd file via the init script to deal where the limits.d may not be available. |
|
I've created a mashup of @chrisroberts' and @ctrabold's versions, so now we have a sane approach to |
thoughtcroft
pushed a commit
to ninefold/chef-elasticsearch
that referenced
this pull request
Jan 30, 2015
While reading the recommendations found [here](http://asquera.de/opensource/2012/11/25/elasticsearch-pre-flight-checklist/#file-descriptors) I thought that it would be a good idea to use `limits.d` instead of hacking the `limits.conf` file directly. This way Chef handles the idempotency itself and we can drop the custom (and hard to read) `not_if` magic. The "chef-ulimit" cookbook uses the same approach: https://github.com/bmhatfield/chef-ulimit/blob/master/definitions/user_ulimit.rb#L13 Tested on Vagrant with Debian 6 and Ubuntu Precise. Closes sous-chefs#101 Closes sous-chefs#118 Fixes sous-chefs#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the recommendations found here I thought that it would be a good idea to use
limits.dinstead of hacking thelimits.conffile directly.This way Chef handles the idempotency itself and we can drop the custom (and hard to read)
not_ifmagic.The result is the following file:
Tested on Vagrant with Debian 6 by removing the two lines from
/etc/security/limits.confand restarting the machine.Calling
ulimit -Hnshowed the expected value.