Move download_url resolving to recipe #227
Conversation
This makes changing elasticsearch version easier from wrapper cookbooks
|
Hi, thanks!, although, this has been debated across couple of issues, and the downside of a patch like this is that you cannot then set a custom URL in your attributes. As I said across multiple issues, the cookbook needs to be refactored, to prevent this problems, have a better test infrastructure etc... I don't have time right now to evaluate the patch, this is something we should consider for the rewrite. |
|
good point! what if it does: download_url = node.elasticsearch[:download_url].empty? ? [node.elasticsearch[:host], node.elasticsearch[:repository], filename].join('/') : node.elasticsearch[:download_url] will you accept or just prefer to refactor the whole thing? thanks |
|
For reference, there's an interesting approach suggested in https://coderanger.net/derived-attributes/, where Noah Kantrowitz proposes interpolating the dynamic parts of attributes with |
This prevents a number of errors and surprises when setting the Elasticsearch version. If the user overrode the node.elasticsearch[:version] property, the download directory and symlinks would be created with the correctly overridden version number. However, the download URL would be computed with the default version number, and thus the incorrect, default version of elasticsearch would be installed. Since there's no need to compute the download filename and URL until node convergence, this patch moves that computation to the default.rb recipe. However, the node.elasticsearch[:filename] and node.elasticsearch[:download_url] attributes, if present, are respected and given preference upon node convergence, so that users still have the capability to override these attributes and thus configure downloads from a custom repository. Related: #100, #180, #178, #240, #179, #245, #227, #245 Closes #242
This makes changing elasticsearch version easier from wrapper cookbooks