Moving computation of download URL from attributes to recipe #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computing attributes like this, in the attributes file, causes really confusing behavior at runtime. Setting ``elasticsearch[:download_url]`` to nil, and computing at runtime instead. User can override the attribute in a wrapper cookbook and the recipe will actually respect that override.
|
Could you please squash these into a single logical commit? Otherwise LGTM. |
|
Will do--closing this pull request and submitting a fresh one with a single commit. |
karmi
pushed a commit
that referenced
this pull request
Oct 13, 2014
This prevents a number of errors and surprises when setting the Elasticsearch version. If the user overrode the node.elasticsearch[:version] property, the download directory and symlinks would be created with the correctly overridden version number. However, the download URL would be computed with the default version number, and thus the incorrect, default version of elasticsearch would be installed. Since there's no need to compute the download filename and URL until node convergence, this patch moves that computation to the default.rb recipe. However, the node.elasticsearch[:filename] and node.elasticsearch[:download_url] attributes, if present, are respected and given preference upon node convergence, so that users still have the capability to override these attributes and thus configure downloads from a custom repository. Related: #100, #180, #178, #240, #179, #245, #227, #245 Closes #242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computation of the download filename and download URL in the
defaults.rbattributes file was causing confusing behavior upon node convergence. If the user overrode thenode.elasticsearch[:version]property, the download directory and symlinks would be created with the correctly overridden version number. However, the download URL would be computed with the default version number, and thus the incorrect, default version of elasticsearch would be installed.Since there's no need to compute the download filename and URL until node convergence, this pull request moves that computation to the
default.rbrecipe. However, thenode.elasticsearch[:filename]andnode.elasticsearch[:download_url]attributes are still recognized and given preference upon node convergence, so that users still have the capability to override these attributes fromniland thus configure downloads from a custom repository.