Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sous chefs adoption #110

Merged
merged 16 commits into from
Oct 28, 2020
Merged

Sous chefs adoption #110

merged 16 commits into from
Oct 28, 2020

Conversation

ramereth
Copy link
Contributor

@ramereth ramereth commented Oct 8, 2020 •
edited
Loading

Description

Describe what this change achieves

Issues Resolved

List any existing issues this PR resolves

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@ramereth
Update Changelog to Sous Chefs
30c556b 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Cookstyle fixes
d0ea6c8 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Update to use Sous Chefs GH workflow
65f35de 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Yamllint fixes
8df24fe 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
MDL fixes
97a580a 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Add missing include for EtcdCookbook::EtcdCommonProperties in etcd_in…
d8a513f 
…stallation_binary

This was actually breaking in the docker tests.

Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Update README to sous-chefs
f0e0d42 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Update metadata.rb to Sous Chefs
29e48b8 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Update test-kitchen to Sous Chefs
d463f88 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Remove support for Amazon Linux 1
d748ea4 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Remove support for CentOS 6
cd96516 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Misc kitchen cleanup
3fa7dd4 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth ramereth force-pushed the sous-chefs-adoption branch 4 times, most recently from d2ddac5 to 07dedb3 Compare October 23, 2020 22:21
@ramereth
Ensure we start etcd with the auto recipe
614f8e2 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth
Fix docker daemon backend storage for test kitchen
af6aa6d 
Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth ramereth marked this pull request as ready for review October 23, 2020 23:11
@ramereth
Exclude broken service-docker-multi suite and exclude opensuse on all…
0e9db74 
… docker

Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth ramereth requested a review from a team October 23, 2020 23:12
detjensrobert
detjensrobert reviewed Oct 23, 2020
View reviewed changes
Copy link

@detjensrobert detjensrobert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move the resource documentation out of the readme and into separate files like apache2 and other cookbooks?

@ramereth
Copy link
Contributor Author

@detjensrobert that would be nice but I don't really have the time to do that with all the other cookbooks we need to adopt. Feel free to tackle it!

damacus
damacus reviewed Oct 26, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
damacus
damacus reviewed Oct 26, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
damacus
damacus reviewed Oct 26, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
damacus
damacus reviewed Oct 26, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
damacus
damacus requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@damacus damacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of the upstream Actions have changed from master to main 👍

Otherwise LGTM

@ramereth @damacus
Update branch name to main for actions
d612553 
Co-authored-by: Dan Webb <dan.webb@damacus.io>
@ramereth ramereth added the Release: Minor Release to Chef Supermarket as a minor release when merged label Oct 26, 2020
axelrtgs
axelrtgs reviewed Oct 28, 2020
View reviewed changes
kitchen.yml Show resolved Hide resolved
@ramereth ramereth merged commit 0646b04 into master Oct 28, 2020
@ramereth ramereth deleted the sous-chefs-adoption branch October 28, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detjensrobert detjensrobert detjensrobert left review comments

@damacus damacus damacus requested changes

@axelrtgs axelrtgs axelrtgs approved these changes

Assignees
No one assigned
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramereth @damacus @detjensrobert @axelrtgs