Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sous Chefs Adoption #14

Merged
merged 16 commits into from
Oct 17, 2020
Merged

Sous Chefs Adoption #14

merged 16 commits into from
Oct 17, 2020

Conversation

ramereth
Copy link
Contributor

@ramereth ramereth commented Oct 8, 2020

Description

Describe what this change achieves

Issues Resolved

List any existing issues this PR resolves

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Amazon Linux doesn't include firefox in any repos.

Signed-off-by: Lance Albertson <lance@osuosl.org>
…method

This properly fixes firefox installation in Debian and Suse systems along with
giving users the option to choose the name of the firefox package they wish to
install on Linux-based systems.

Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Signed-off-by: Lance Albertson <lance@osuosl.org>
Also fix test for Windows.

Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth ramereth marked this pull request as ready for review October 17, 2020 17:35
@ramereth ramereth added the Release: Minor Release to Chef Supermarket as a minor release when merged label Oct 17, 2020
@ramereth ramereth requested a review from a team October 17, 2020 17:40
@tas50 tas50 merged commit 814c0d7 into master Oct 17, 2020
@tas50 tas50 deleted the sous-chefs-adoption branch October 17, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants