New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grafana + improve nginx integration #7

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kamaradclimber
Contributor

kamaradclimber commented Mar 24, 2014

No description provided.

@JonathanTron

This comment has been minimized.

Show comment
Hide comment
@JonathanTron

JonathanTron Mar 24, 2014

Collaborator

Why should we restart nginx when kibana is updated? It's reloaded when the site config changes, but I don't see why it should change when the javascript is updated, maybe I'm missing something?

Collaborator

JonathanTron commented Mar 24, 2014

Why should we restart nginx when kibana is updated? It's reloaded when the site config changes, but I don't see why it should change when the javascript is updated, maybe I'm missing something?

@kamaradclimber

This comment has been minimized.

Show comment
Hide comment
@kamaradclimber

kamaradclimber Mar 24, 2014

Contributor

maybe I'm wrong but it seems that this is a way to bust caches ?

Contributor

kamaradclimber commented Mar 24, 2014

maybe I'm wrong but it seems that this is a way to bust caches ?

@JonathanTron

This comment has been minimized.

Show comment
Hide comment
@JonathanTron

JonathanTron Mar 24, 2014

Collaborator

The only cache a restart of Nginx would clear is the one from open_file_cache, but given it's not enabled in the default config, I prefer not to restart it without reason.

Collaborator

JonathanTron commented Mar 24, 2014

The only cache a restart of Nginx would clear is the one from open_file_cache, but given it's not enabled in the default config, I prefer not to restart it without reason.

@kamaradclimber

This comment has been minimized.

Show comment
Hide comment
@kamaradclimber

kamaradclimber Mar 24, 2014

Contributor

ok I'll update the PR tomorrow

Contributor

kamaradclimber commented Mar 24, 2014

ok I'll update the PR tomorrow

@JonathanTron

This comment has been minimized.

Show comment
Hide comment
@JonathanTron

JonathanTron Mar 24, 2014

Collaborator

Thanks!

Collaborator

JonathanTron commented Mar 24, 2014

Thanks!

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.