Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library update for Chef 13 #104

Merged
merged 3 commits into from
Feb 1, 2018
Merged

library update for Chef 13 #104

merged 3 commits into from
Feb 1, 2018

Conversation

chrisminton
Copy link
Contributor

@chrisminton chrisminton commented Nov 18, 2017 •
edited

  • Update vault::service library to remove deprecation warnings
  • Update metadata to correct Foodcritic errors

@codecov-io
Copy link

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #104   +/-   ##
=====================================
  Coverage      53%    53%           
=====================================
  Files           2      2           
  Lines         100    100           
=====================================
  Hits           53     53           
  Misses         47     47
Impacted Files Coverage Δ
libraries/vault_service.rb 52.27% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc303e5...c728b25. Read the comment docs.

@chrisminton chrisminton changed the title Vault::service update for Chef 13 library update for Chef 13 Nov 27, 2017
@johnbellone johnbellone merged commit e6fff32 into sous-chefs:master Feb 1, 2018
@evralston evralston mentioned this pull request Apr 12, 2018
Closed
@evralston evralston mentioned this pull request Nov 28, 2018
Closed
@lock
Copy link

lock bot commented May 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2019
@chrisminton chrisminton deleted the chef-13-fix branch May 19, 2019 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnbellone johnbellone johnbellone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisminton @codecov-io @johnbellone