Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default broker config. options are defined using underscore notation #55

Closed
mthssdrbrg opened this issue Aug 18, 2014 · 1 comment
Closed

Default broker config. options are defined using underscore notation #55

mthssdrbrg opened this issue Aug 18, 2014 · 1 comment

Comments

@mthssdrbrg
Copy link
Contributor

Realized that, currently, host_name and broker_id are defined as follows in attributes/default.rb:

default.kafka.broker.broker_id = node.ipaddress.gsub('.', '').to_i % 2**31

default.kafka.broker.host_name = node.hostname

To override these one is forced to use the underscore notation, or otherwise they'll appear twice in the rendered configuration file.
Obviously this should be oblivious to how one defines their configuration, or there should be one and only one way to structure the broker configuration attributes.
@mthssdrbrg mthssdrbrg added the bug label Aug 18, 2014
mthssdrbrg added a commit that referenced this issue Aug 19, 2014
@mthssdrbrg
Version bump to v0.5.1
e948fbb 
Bug fix release with a fix for #55.
johndotpub pushed a commit to brigade/kafka-cookbook that referenced this issue Oct 16, 2014
@mthssdrbrg
Set defaults in a separate (private) recipe
bb0c633 
Since one can define broker configuration options in a number of
different ways we cannot really set broker defaults in an attributes
file.

Instead we set them in a `_defaults` recipe, but only if they aren’t
already set to something, as we don’t want to override what a user has
already set.

Closes sous-chefs#55.
johndotpub pushed a commit to brigade/kafka-cookbook that referenced this issue Oct 16, 2014
@mthssdrbrg
Version bump to v0.5.1
05061d0 
Bug fix release with a fix for sous-chefs#55.
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mthssdrbrg