Clean server install resource #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the following properties: - mycnf_file - extconf_directory - data_directory - external_pid_file - port - initdb_locale Updated documentation to reflect the changes.
|
Looks good! can you remove amalon-linux2 from the Ci matrix too, please? |
|
@fernandoaleman I've rebased. Can you double check that makes sense please? |
damacus
added
the
Release: Patch
- Update documentation - Set tests to mariadb version 10.11 - Remove tests for mariadb versions 10.3 and 10.4
|
@damacus I added another commit defaulting mariadb to version 10.11 in all the testing and removing tests on version 10.3 and 10.4. However, I noticed that |
|
@damacus This PR keeps failing CI because of the |
|
If you could for now until I fix the logic I'm not sure which bit of the permissions is failing right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused properties from server_install resource
Removed the following properties:
Updated documentation to reflect the changes.
Fix default pid file for rhel, fedora and amazon
Updated default mariadb version to 10.11 in all tests
Check List
## Unreleased