Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused properties from server_install resource #365

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Conversation

fernandoaleman
Copy link
Contributor

Description

Removed the following properties:

  • mycnf_file
  • extconf_directory
  • data_directory
  • external_pid_file
  • port
  • initdb_locale

Updated documentation to reflect the changes.

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

Removed the following properties:

- mycnf_file
- extconf_directory
- data_directory
- external_pid_file
- port
- initdb_locale

Updated documentation to reflect the changes.
@fernandoaleman fernandoaleman mentioned this pull request Apr 14, 2023
3 tasks
@fernandoaleman
Copy link
Contributor Author

@damacus Would you like for me to update the metadata version and CHANGELOG when I create a PR or will someone do that once the PR is approved?

@fernandoaleman fernandoaleman marked this pull request as ready for review April 14, 2023 18:00
@fernandoaleman fernandoaleman requested a review from a team as a code owner April 14, 2023 18:00
@damacus damacus added the Release: Patch Release to Chef Supermarket as a version patch when merged label Apr 16, 2023
@damacus damacus enabled auto-merge (squash) April 16, 2023 18:35
@damacus damacus merged commit 4973261 into main Apr 16, 2023
@damacus damacus deleted the clean-resources branch April 16, 2023 18:36
@kitchen-porter
Copy link
Contributor

Released as: 5.2.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Patch Release to Chef Supermarket as a version patch when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants