Fix deprecation warning, and fix chef registering a changed resource on every run #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
Deprecated features used!
Cannot specify both default and name_property together on property path of resource motd_tail. Only one (name_property) will be obeyed. In Chef 13, this will become an error. Please remove one or the other from the property. at 1 location:
- /var/chef/cache/cookbooks/motd-tail/libraries/resource_motd_tail.rb:27:in `<class:MotdTail>'
```
Signed-off-by: Mark Harrison <mark@mivok.net>
The converge by causes a change to be registered on every chef run, even when the motd file is unchanged. In addition, it's not necessary to have the converge_by in place as the content inside is a normal chef resource. Signed-off-by: Mark Harrison <mark@mivok.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two fixes: