[COOK-4095] remove explicit ref to libpq-dev package #99
Conversation
There is no libpq-dev package on RedHat 6 (maybe other versions too). There is already code which installs client packages - this is supposed to deal with installing postgresql devel packages.
|
Now I can see there was another PR (#96) which attempts to address the same problem. However it tries to keep the old behaviour unchanged for There is a configuration with default attributes - it already includes libpq-dev as default for the relevant platforms. If we want a more convenient configuration: maybe makes sense to have a separate |
|
👍 to this, I've been following the PR's where it got added (#88), and I suggested this exact change, to remove this block then, but it wasn't before it got merged. |
|
I rebased that branch to fix my e-mail. |
|
Bump. Has this PR been reviewed or considered by a maintainer yet? As I mentioned before, I'd been following the issues around this, and definitely agree this is the change that should be made to fix the existing situation of being currently broken on all platforms other than debian/ubuntu |
|
About a week ago the jira ticket has been updated changing status to reviewed: |
|
please merge this already! |
|
Can we get this merged? |
|
What else needs to happen to get this merged? How can we help? Thanks. |
|
Ping @fnichol @portertech who's the right person to take a look at this? This relatively simple PR has been waiting to get merged for a while, and without it this cookbook is broken on all non-debian platforms. I'm happy to talk to someone through to help grok the changes if need be. |
|
selfishly +1'ing this to keep track on when this gets merged in :) |
|
This has been merged into https://github.com/hw-cookbooks/postgresql/tree/develop. We'll add some minimal testing around this branch and hopefully generate a new release within a week. Thank you. |
|
Thanks! |
FIXES sous-chefs#114 To recap -------- This package was originally added as a mis-fix because someone inadvertently clobbered their client packages. sous-chefs#88 Apart from being "the wrong way" to fix the problem, it also resulted in breaking centos/redhat. CentOS was fixed by wrapping in an "if debian?" here: https://github.com/hw-cookbooks/postgresql/pull/96/files But really it never should have been added, per @jeremyolliver sous-chefs#96 (comment) This block was to be removed in sous-chefs#99 But somehow this code is still [in develop](https://github.com/hw-cookbooks/postgresql/blob/develop/recipes/ruby.rb#L57). It looks like sous-chefs#99 targeted a different base branch than sous-chefs#96, so perhaps there was a botched merge. Phew!
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is to address https://tickets.opscode.com/browse/COOK-4095 - explicit reference of
libpq-devinpostgresql::rubyis aborting the recipe execution.There is no
libpq-devpackage on RedHat 6 (maybe other versions too). There is already code which installs client packages - this is supposed to be the way to deal with installing postgresql devel packages.