Test #1
Open
Test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Make exception for storage" This reverts commit a3035f8.
There was disagreement about the returned type between the doc comment and the code itself.
* queue: use ./.env * file: skip large file test except playback * blob: un-skip live tests ex. browser, quick query * record undelete * fix intermittent test failure: wait 30s after containerClient.setAccessPolicy() * Add enableVersioning parameter to test-resources.json * Add ARM template parameter to enable versioning * "boolean" -> "bool" Co-authored-by: Lin Jian <ljian3377@gmail.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com>
There's some difference between `npm run unit-test:node`/`npx _mocha ...` and `node ./node_modules/mocha/bin/_mocha` which we used to launch the debugger. The former did a probe to find a `mocha` executable in a set of paths and in our case it finds `./node_modules/.bin/mocha` and execute it. `./node_modules/.bin/mocha` is actually a shell script wrapping around `./node_modules/mocha/bin/mocha` and setting the `NODE_PATH` environment variable. One of the path included in this variable is particularly important: `<project-root>/common/temp/node_modules/.pnpm/node_modules`. It helped to resolve the indirect dependency of `nock` which otherwise wouldn't resolve under storage libraries' `./node_modules/`. So just launching `node ./node_modules/mocha/bin/_mocha` would lead to an error of `Cannot find module 'nock'`. This change adds a `NODE_PATH` environment variable to the VS Code launch configuration using `ts-node`. It should be safe to only include the `common/temp/node_modules/.pnpm/node_modules` because in our repository, all libraries' dependencies are symbol links to packages under pnpm's `node_modules` directory. The other configuration of debugging unit tests does not have this issue, possibly because the test file is a bundle. Fixes Azure#9901.
Co-authored-by: Lin Jian <ljian3377@gmail.com>
…fact parameter option in pipeline (Azure#9948)
…eBusMessage and ATOM API (Azure#10003) * Rename userProperties under ManagementClient too * fix test utils * rename userProps in the tests * one leftover * API Report * Changelog * fix build failure
Co-authored-by: azure-sdk <azuresdk@microsoft.com>
…ure#10018) In function `customConsoleLog()` we save `window.console.log` to a local variable and use this variable to log to real console. The problem is that when `customConsoleLog()` is called multiple times, `window.console.log` is no longer the original one, and we end up nesting the modified `log` function again and again. This PR saves the original console log function to a module level variable instead so it's not wrapped multiple times. * Allow overriding consoleLog for testing
…ded (Azure#10013) We use an async function to add a recorded request to an array then save the array to files when recorder stops. However we did not wait for the async function to complete, which leads to recording missing requests. This issue only happens in the browser case. In Node it is done in synchronous way. This change makes recorder to wait until all the recorded requests are added before saving them. All the tests have been updated to await for `recorder.stop()`. Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
…we wait for all pollers (Azure#10031) * [Key Vault Certificates] Test timeout need to be increased since now we wait for all pollers * dependency-testing timeout
* Azure SDK dev-tool first pass * [dev-tool] dev-tool dev-samples and fixes to all commands * Nested command structure * Better argument parsing, type-checking, and recursive command structure. Added support for running a single sample. * Added dev-tool README * [ai-text-analytics] Update package.json to use new script. * Removed some development cruft * prettier + eslint * Quick fix to ParsedOptions type * WIP * Command framework improvements * Basic unit-tests for package resolution. * One more test, assorted changes * README update * Migrated all packages with sample code to use dev-tool * Added dummy integration-test stub * Added dummy integration-test stub for eslint plugin * Added dummy integration-test:browser stubs * Added dev-tool dependency to packages using it * Corrected build:samples step in package.json * WIP * [dev-tool] ts-to-js command * [dev-tool] leaf command test * Fixed more deeply nested samples due to shared code
…xported (Azure#10549) * @internal @ignore tags for the ones that aren't exported * Update sdk/servicebus/service-bus/src/serializers/ruleResourceSerializer.ts Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> * Update sdk/servicebus/service-bus/src/util/utils.ts * Update sdk/servicebus/service-bus/src/util/crypto.ts Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> * left over un-exported items Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
* Generated from c307faa1f96e19d7598b4030b9e5382ac7308e5d Add Url Signing action definition * release cdn * change version * Update package.json * Update cdnManagementClientContext.ts Co-authored-by: SDK Automation <sdkautomation@microsoft.com> Co-authored-by: root <root@cjf.mih3djy34d2u5g04k3hmghvbfb.bx.internal.cloudapp.net>
* [Text Analytics] Remove handling code for generic errors * update recordings * add tests for inner error codes and messages * throw a custom exception * addressed Will's comments
…in our SDKs (Azure#10145) * update the CONTRIBUTING.md guide to point to the automatic debug configuration feature in vscode * delete all custome vscode configs * factoring out coverage scripts so that mocha with ts-node can work with vscode debugger
…on on the READMEs (Azure#10572) * [Key Vault] Spotted a remaining reference to 7.1-preview on the READMES * also, apiVersion to serviceVersion * spotted one issue with the keys README samples
* Wraps URL with checkURL function * Adds changelog bugfix
…zure#10576) * fixing the bad dist-esm folders on the resulting artifacts By loading the package.json in the test files, the dist-esm folder was including a copy of the package.json, breaking the whole folder (thus also source maps, etc). * SDK_VERSION and packageVersion should match in the browsers too * formatting * using path instead of concatenations
* Added Test Cases for Search Index Client * New Recordings * Additional Changes * Another set of recordings * Some more changes * Refactorings based on PR Comments * Formatting Changes
…0207) * Add an EdmGUID class * Add an EdmInt64 class * Add serialization.ts file * Make client methods public * Serialize entities in TableServiceClient * Deserialize entities in TableServiceClient * Add support for Binary data serialization * Fix deserialization for getEntity * Fix deserialize return type * Fix getEntity return type * Include other EDM types for serialization * Remove isUint8Array method * Rename econde and decode functions to include base64 * use isValidUuid from core-http * Add isSafeInteger to Int64 class * Convert scientific notation to standard notation * Regenerate using the new swagger * Add generic types to entity operations * Use types instead of interfaces * Update serializer * Add unit tests for serialization/deserialization * Fix PR comments * Add unit tests for bufferSerializer utility function * Fix PR comments
* [Key Vault] Our version split in the changelog breaks the release build * fixing integration-test userAgent tests * wild .only appeared, removing it was super effective
* Add live tests for index client * Updated/Added Service Recordings * Minor Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.