Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit/create asset page #770

Merged
merged 28 commits into from
Jul 23, 2024
Merged

feat: edit/create asset page #770

merged 28 commits into from
Jul 23, 2024

Conversation

kulgg
Copy link
Collaborator

@kulgg kulgg commented Jul 18, 2024

This PR replaces the existing create/edit asset dialogs with improved full page "wizard" forms.
I also added a bunch of inter font variants and made that the main font. The Open Sans font we had before had no variants as well meaning that we could not even do things likefont-semibold in effect.

closes https://github.com/sovity/PMO-Software/issues/1366
closes https://github.com/sovity/PMO-Software/issues/983
closes https://github.com/sovity/PMO-Software/issues/1309

@kulgg kulgg enabled auto-merge (squash) July 22, 2024 10:03
@kamilczaja kamilczaja self-requested a review July 22, 2024 14:51
@richardtreier richardtreier requested review from richardtreier and removed request for kamilczaja July 23, 2024 06:55
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of questions or gaps to define. Our task list on the board is not up to date unfortunately.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
src/styles.scss Show resolved Hide resolved
src/styles.scss Outdated Show resolved Hide resolved
src/styles.scss Outdated Show resolved Hide resolved
src/tailwind.scss Show resolved Hide resolved
tailwind.config.js Show resolved Hide resolved
richardtreier and others added 3 commits July 23, 2024 17:56
…ui into 2024-07-17-create-asset-page

# Conflicts:
#	src/app/component-library/edit-asset-form/edit-asset-form/edit-asset-form.component.html
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulgg kulgg merged commit fb0c02e into main Jul 23, 2024
13 checks passed
@kulgg kulgg deleted the 2024-07-17-create-asset-page branch July 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants