fix: DNS upstream connection close

sower-proxy · May 19, 2022 · 795bf73 · 795bf73
1 parent 3412643
commit 795bf73
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/router/dns.go b/router/dns.go
@@ -34,20 +34,22 @@ func (r *Router) ServeDNS(w dns.ResponseWriter, req *dns.Msg) {
 	if err != nil {
 		resp, rtt, err = r.dns.ExchangeWithConn(req, conn)
 	}
-	select {
-	case r.dns.connCh <- conn:
-	default:
-		conn.Close()
-	}
 
 	log.DebugWarn(err).
 		Dur("rtt", rtt).
 		Str("question", req.Question[0].String()).
 		Msg("exchange dns record")
 	if err != nil {
 		_ = w.WriteMsg(r.dnsFail(req, dns.RcodeServerFailure))
+		conn.Close()
+
 	} else {
 		_ = w.WriteMsg(resp)
+		select {
+		case r.dns.connCh <- conn:
+		default:
+			conn.Close()
+		}
 	}
 }