Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scannon #24

Merged
merged 18 commits into from
Sep 25, 2023
Merged

Scannon #24

merged 18 commits into from
Sep 25, 2023

Conversation

StevenCannon-USDA
Copy link

New content under about and resources (genome_info and iframes to dscensor)

Copy link

@maxglycine maxglycine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should be explicit so how about 👍
"and genomic data accessions at the major genomic data repositories: GenBank, EMBL, DDBJ and variant data at the European Variation Archive (EVA)"

@jd-campbell
Copy link

@StevenCannon-USDA did you still need a review of this branch?

@maxglycine
Copy link

Your branch will not run in codespaces so I can’t really see what you did. One of the drawbacks of relying on liquid to render.

@StevenCannon-USDA StevenCannon-USDA marked this pull request as draft September 13, 2023 00:44
@StevenCannon-USDA
Copy link
Author

@StevenCannon-USDA did you still need a review of this branch?

@jd-campbell No thanks. There's more that I'd like to do. I have switched this branch to "draft" status.

@StevenCannon-USDA StevenCannon-USDA marked this pull request as ready for review September 20, 2023 00:15
@StevenCannon-USDA
Copy link
Author

Quite a few items for review, please:

  • Under GENOMICS (/resources), new text in the overview section, including a link to ...
  • ... a new page /resources/genome_info/ , with content from https://soybase.org/genome_assemblies.php
  • Fixed all remaining broken links (I think; we'll see if anything new crops up)
  • At /about , added a link to about/soybase_about/index.html
  • Some minor table-styling changes at about/lgs_and_chromosomes/index.html

Copy link

@maxglycine maxglycine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as code. Thanks.

Copy link

@maxglycine maxglycine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@StevenCannon-USDA StevenCannon-USDA merged commit 601f40b into main Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants