fix(components): 修复搜索回车不关闭弹框、点击无法跳转的问题 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honghuangdc
added a commit
that referenced
this pull request
Jun 1, 2024
|
按钮的聚焦还是得保留，这个直接去掉修饰符 prevent 就行 |
|
好的，那我把组件那边的去掉吧，放到header的各个搜索和主题配置那里，这两个会因为聚焦产生一些预期之外的反馈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #466
1、控制台报错是因为阻止默认事件有点问题，可能是事件传递在vue中有更新？我看只有里面的click会触发这个
enter事件，所以直接移里面去做了2、除此之外回车触发跳转后弹窗会被重新打开，经过测试发现是
header的按钮持续聚焦导致的，在按钮聚焦的时候只要在页面内按了回车都会导致按钮被触发点击事件，结果思考还是建议取消ButtonIcon组件内按钮的可聚焦状态，这样在不影响现有功能的情况下，有利于减少某些页面内绑定了回车事件时可能出现的bug