Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added signature separator option plus some refactoring #114

Merged
merged 3 commits into from Apr 20, 2021

Conversation

AckslD
Copy link
Contributor

@AckslD AckslD commented Apr 19, 2021

closes #113

I started adding an option to change the default '--' to separate the content and signature of a message. While doing so I also merge some common code for the build_xxx functions.

Copy link
Owner

@soywod soywod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way you refactored, it looks cleaner to me!

src/msg/model.rs Outdated Show resolved Hide resolved
src/config/model.rs Outdated Show resolved Hide resolved
@soywod soywod merged commit 6284b0c into soywod:master Apr 20, 2021
@soywod
Copy link
Owner

soywod commented Jun 3, 2021

@AckslD In fact, the double dash seems to be a standard. In the .signature file, the dashes should not be included because they are added automatically. I tried with emacs and thunderbird and both have the same behaviour. I think we should reconsider this PR to align the tool with standards.

I propose sth close to what you originally proposed: we introduce a new boolean signature-delimiter. If true (the default) then we show the delimiter before the signature. If not then only the signature is shown. Those who want a custom delimiter can disable the signature-delimiter and include it inside their signature. What do you think?

@AckslD AckslD deleted the 113-signature-seperator branch June 4, 2021 08:34
@AckslD
Copy link
Contributor Author

AckslD commented Jun 4, 2021

@soywod I see, yeah that make sense to me 👍

@soywod
Copy link
Owner

soywod commented Aug 4, 2021

@AckslD I pushed the changes (a6b30b7). I introduced signature-delimiter as on optional string instead of a boolean, I thought it would be more UX. In fact it really looks like your initial PR... sorry for all those changes.


It's been a while I did not see you here, I hope your are doing well!

@AckslD
Copy link
Contributor Author

AckslD commented Aug 5, 2021

Nice @soywod! :)


I started a new job so been quite busy with that :) Hope you're doing well also!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants