-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiments around config wizard #312
Conversation
So I've a question here @soywod : Do you agree, if I use
What do you think? Please note that I just quickly went through their readme and a little bit through their docs so it might happen, that I skipped some important parts. |
|
@soywod little question here (I think that I've asked that already once, but I can't find my question anymore): /// Represents the user account.
#[derive(Debug, Default, Clone)]
pub struct AccountConfig {
/// Represents the name of the user account.
pub name: String,
/// Makes this account the default one.
pub default: bool,
/// Represents the display name of the user account.
pub display_name: String,
...
} What's the difference, between [name]
name = display_name ? |
The |
Hi! I've got another questiong: As you mentioned, it'd be pretty nice if we could get the host-data just by looking up the hostname of the e-mail-address. So I'm wondering if we should store the same |
Mmmh good point. I don't know if downloading it every time is the good option (although, it looks appealing). Maybe we could download it inside himalaya and update it time to time manually (at least for a first version)? What do you think? |
Hm... I could imagine, that 17.5KB is quite a lot for some people so I think that downloading it into himalaya is fine. I think an optional question to the user, if the wizard should try to figure the host out on its own, can be added, so if the user thinks that downloading a |
Yeah, sounds good. Maybe sth like "configuration type: manual | auto". |
huh, why did you delete the development branch? |
oh I see, you released a new version |
The auto-delete branch feature deleted it after having merged |
No problem |
How is it going with this feature? I'm asking because some breaking changes are coming (see https://github.com/soywod/himalaya/discussions/345) and I'm afraid we will reach the same conflicting problems than with the TUI. After the I'm sorry for all those breaking changes. I'm aware that I may also have broken your motivation after the TUI and now the config wizard. Himalaya comes from far (it's been years I'm experimenting sth around), and it was hard to find the place and the direction of this tool. It is only since the |
Welp, I can't find any time for this feature at the moment. As I already said I'm in my exam-session at this moment.
Don't worry, there are only about 100 LOC which I changed, so it's not a big lost.
No need to apologize :) I can't complain if it improves himalaya and provides a better API for the TUI. Anyway, my motivation is not completely gone for the TUI. It just became smaller since I found another project which seems to be more interesting to me. So I think, that I'll still participate at the TUI when the time comes. But for the time being I need to pass my exams first xD Should I close this PR? |
Yeah we can close. We will come back on it later, when the time comes.
Good luck dude 🤞 💪 |
This PR should give himalaya a config wizard like
mutt-wizard
.