Flags to enable telescope preview and to choose picker #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soywod
requested changes
Apr 13, 2021
|
Thanks for the feedback @soywod, I made some updates based on this |
|
Thank you so much ❤️ |
|
@AckslD I realized we forgot to update the vim readme about those new options! |
|
Good point @soywod! Unfortunately I'm not able to contribute much at the moment :) |
|
I added a configuration section in the vim README with the options you introduced 😉 |
koalp
pushed a commit
to koalp/himalaya
that referenced
this pull request
Sep 17, 2021
* Flags to enable telescope preview and to choose picker * 4 spaces -> 2 space lua * changes to align with repo code-style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #92
@soywod I also did some restructuring of the code around this and the lua file. Not necessary for the added feature but I found it a bit more readable. Feel free to let me know if you don't like this structure.