Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Logging #17

Merged
merged 6 commits into from
Jan 21, 2024
Merged

Implement Logging #17

merged 6 commits into from
Jan 21, 2024

Conversation

nik3212
Copy link
Member

@nik3212 nik3212 commented Jan 19, 2024

No description provided.

@nik3212 nik3212 self-assigned this Jan 19, 2024
@nik3212 nik3212 changed the title Implement logging [WIP] Implement logging Jan 19, 2024
@nik3212 nik3212 changed the title [WIP] Implement logging [WIP] Implement Logging Jan 19, 2024
@spacecode-github-bot
Copy link

spacecode-github-bot commented Jan 19, 2024

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (65f1cd1) 82.24% compared to head (24c3b35) 78.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #17      +/-   ##
==========================================
- Coverage   82.24%   78.43%   -3.81%     
==========================================
  Files          45       49       +4     
  Lines        1385     1632     +247     
==========================================
+ Hits         1139     1280     +141     
- Misses        246      352     +106     
Files Coverage Δ
Sources/Flare/Classes/IFlare.swift 100.00% <ø> (ø)
.../ConfigurationProvider/ConfigurationProvider.swift 100.00% <100.00%> (ø)
...re/Classes/Providers/IAPProvider/IAPProvider.swift 90.99% <ø> (ø)
...es/Providers/PaymentProvider/PaymentProvider.swift 99.15% <100.00%> (+0.11%) ⬆️
...es/Providers/ProductProvider/ProductProvider.swift 100.00% <100.00%> (ø)
...eceiptRefreshProvider/ReceiptRefreshProvider.swift 100.00% <100.00%> (ø)
...viders/RedeemCodeProvider/RedeemCodeProvider.swift 100.00% <ø> (ø)
Sources/Flare/Classes/Flare.swift 91.03% <84.62%> (-1.73%) ⬇️
Sources/Flare/Classes/Common/Logger.swift 89.19% <89.19%> (ø)
...urces/Flare/Classes/Models/VerificationError.swift 0.00% <0.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

- Integrate the `log` package
- Write a wrapper for logging
- Implement a few events to be logged
@nik3212 nik3212 changed the title [WIP] Implement Logging Implement Logging Jan 21, 2024
@nik3212 nik3212 merged commit 33804c9 into dev Jan 21, 2024
22 checks passed
@nik3212 nik3212 deleted the feature/logging branch January 21, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants