Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel control #607

Merged
merged 13 commits into from
May 25, 2023
Merged

Fix wheel control #607

merged 13 commits into from
May 25, 2023

Conversation

vexandmore
Copy link
Contributor

Assignee Section

Description

  • Makes it possible to turn gradually by pressing R2 and using the joystick
  • uninverts the right stick x axis

The approval from all software team leads is necessary before merging.

Reviewer Section

Aside from local testing and the General Integration Test it is implied that static analysis should be included in the verification process.

For Pull Requests that do not include code changes, it is not required to perform the tests above.

Copy link
Member

@RealWilliamWells RealWilliamWells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just make sure to disable usb debug mode before merging!

robot/rover/internal_comms/include/CommandCenter.h Outdated Show resolved Hide resolved
AymanShe
AymanShe previously approved these changes May 24, 2023
Copy link
Collaborator

@AymanShe AymanShe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Changes mostly make sense. Playtest it and you should be good.

@vexandmore vexandmore dismissed stale reviews from AymanShe and RealWilliamWells via b513788 May 25, 2023 00:58
AymanShe
AymanShe previously approved these changes May 25, 2023
Copy link
Collaborator

@AymanShe AymanShe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels good to be ever so slightly involved with you guys ❤🤖

@RealWilliamWells RealWilliamWells merged commit f5dd144 into master May 25, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants