Cache HasCustomAttribute #5269
Open
Cache HasCustomAttribute #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes debug a lot faster. No idea if static semaphoreslims are bad but my game didn't explodeTM.
PJB3005
reviewed
Jun 25, 2024
|
|
||
| namespace Robust.Shared.Utility | ||
| { | ||
| public static class TypeHelpers | ||
| { | ||
| private static SemaphoreSlim _hasSlim = new(1); | ||
| private static Dictionary<MemberInfo, Dictionary<Type, bool>> _hasAttribute = new(); |
There was a problem hiding this comment.
Suggested change
| private static Dictionary<MemberInfo, Dictionary<Type, bool>> _hasAttribute = new(); | |
| private static readonly Dictionary<MemberInfo, Dictionary<Type, bool>> _hasAttribute = new(); |
| @@ -183,7 +188,18 @@ public static bool IsBackingField(this MemberInfo memberInfo) | |||
|
|
|||
| public static bool HasCustomAttribute<T>(this MemberInfo memberInfo) where T : Attribute | |||
| { | |||
| return memberInfo.GetCustomAttribute<T>() != null; | |||
| using (_hasSlim.WaitGuard()) | |||
There was a problem hiding this comment.
Just use lock() on the dictionary instead.
If you want me to do it I can do it, it's primarily dirty and addcomp calls afaik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes debug a lot faster. No idea if static semaphoreslims are bad but my game didn't explodeTM.
Resolves #5268