Getting gibbed/deleted crashes your client

[VasilisThePikachu]

Description

Seen a bunch of people complaining about this, especially when they get deleted by an immovable rod mostly.

Reproduction

1. Get your character deleted somehow
2. crash
   (not reproduced)

[VasilisThePikachu]

Personally cant repro this. Do notice immovable rod sends you to nullspace/"frezes" you one frame before the rod hits you. But not crashing the game. In both cases I was able to /ghost out

[VasilisThePikachu]

I should probably mention. If you crash cause of this. PLEASE send us logs OR copy the error here

[Doctor-Cpu]

Can easily replicate it by standing where the arrival shuttle docks. Will just freeze the client.

What my clients terminal outputs:
[INFO] system.map: Grid NT-Arrivals 1101 (115/n27070) changed parent. Old parent: map 9 (107/n25891). New parent: FTL (116/n27643) [INFO] system.map: Grid NT-Arrivals 1101 (115/n27070) changed parent. Old parent: FTL (116/n27643). New parent: Station map (98/n14) [INFO] system.map: Grid NT-Arrivals 1101 (115/n27070) changed parent. Old parent: Station map (98/n14). New parent: FTL (116/n27643) [INFO] system.map: Grid NT-Arrivals 1101 (115/n27070) changed parent. Old parent: FTL (116/n27643). New parent: map 9 (107/n25891) [INFO] system.map: Grid NT-Arrivals 1101 (115/n27070) changed parent. Old parent: map 9 (107/n25891). New parent: FTL (116/n27643) [INFO] system.map: Grid NT-Arrivals 1101 (115/n27070) changed parent. Old parent: FTL (116/n27643). New parent: Station map (98/n14) [INFO] player: Detaching local player from Amblyocarenum Gemmosum (124/n41420, MobArachnid, localhost@DoctorCpu). [INFO] player: Local player is no longer attached to any entity.

[potato1234x]

can repro by admin smite gibbing yourself

[Jezithyr]

can repro by admin smite gibbing yourself

This might be due to minds breaking when your brain gets deleted during gibbing. When I tested the gibbing refactor, I tested it with part dropping and deletion modes and it worked fine. So I don't think it's gibbing

[pissdemon]

Did someone report an actual crash to desktop? I'm sure people see their game "freezing up" (game world getting stuck on the last frame) and call it a "crash". It's compounded by the fact the only way to get the game to a "working" state again is by using a console command: I would imagine a lot of players have no idea that there even is a console. To those players the game might as well seem "crashed" and they will report it as a crash.

Case in point. And here too where they call it a crash even though they are describing the same stuff.

[thebadman4662]

AFAIK its not crash but "freeze", heard you can just /ghost to unfreeze the game but I have yet to get round removed by something like rod or meatspike to test it.

[pissdemon]

Yes, you can just /ghost out of it, but my point is people might report it as "my game has crashed" because they don't know that's the workaround; not that a workaround should be required in the first place.

[pissdemon]

As for what's going on:

Stuff that wants to gib calls C.S.BodySystem.GibBody(). Calling it with the argument gibOrgans set to false (the default) doesn't actually "gib" as I would expect from the method name. Blood is spawned, but no organs are dropped, and the player that gets gibbed get deleted.

Which is the most important part because it makes it look as though their game has frozen/crashed (especially to someone who doesn't know about /ghost and sees the only solution as restarting the game).

Calling it with gibOrgans: true seems to make it work as expected, organs drop to the ground and the player is transferred to their brain.

It seems what actually happens when you call GibBody(uid, gibOrgans: false) is that it processes your body parts but your organs never end up being dropped, and the body parts don't get dropped either. Everything is just gone, even when running entities with BodyPart or entities with Organ. I dunno why the "gibOrgans" parameter is even named what it is, when setting it to true causes your organs to drop and false makes them get deleted.

The only things calling it with false are:

• the shuttle gibbing behavior (changing that with Admin log shuttle gibbing + Make shuttle gibbing and immovable rods drop organs and correctly put player in ghost #27114)
• immovable rod gibbing behavior
• meat spike (dunno if dropping organs is intended here, it would kind of make sense, since butchers take out the organs)

All these delete the player without their mind being transferred first, putting the players into nullspace and making it look like you "crashed".

[VasilisThePikachu]

In my opinion all the stuff you described should be actually gibbing. Hell it should gib by default. Especially rod

[pissdemon]

In my opinion all the stuff you described should be actually gibbing. Hell it should gib by default. Especially rod

I can just put add gibOrgans: true to all the things I listed in #27114 since it's already got one in there.

Though the meat spike might drop animal organs then from monkies if I do, just as a note. Could get messy when people butcher 6 animals at once. Lots of lizardpeople food I guess?

[VasilisThePikachu]

In my opinion all the stuff you described should be actually gibbing. Hell it should gib by default. Especially rod

I can just put add gibOrgans: true to all the things I listed in #27114 since it's already got one in there.

Though the meat spike might drop animal organs then from monkies if I do, just as a note. Could get messy when people butcher 6 animals at once. Lots of lizardpeople food I guess?

Keep it off for the meat spike ig that'd something to decide on another day

[pissdemon]

Will file another bug for the meatspike then because it still "freezes" your game if you are the victim and you are still in your body when you get spiked.