Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need more job & antag selection tests #28626

Open
5 tasks
ElectroJr opened this issue Jun 5, 2024 · 0 comments
Open
5 tasks

Need more job & antag selection tests #28626

ElectroJr opened this issue Jun 5, 2024 · 0 comments
Labels
Difficulty: 2-Medium A good amount of codebase knowledge required. Issue: Test coverage This issue relates to a need for more integration testing. Status: Untriaged Somebody go through and give this appropriate labels

Comments

@ElectroJr
Copy link
Contributor

ElectroJr commented Jun 5, 2024 •
edited

As revealed by the recent bout of antag related bugs, we really need more antag & game rule related tests. At the very least, we should add tests that could have prevented:

Adding job/antag/game-rule tests should be significantly easier with the ability to add dummy clients. If people aren't sure about how to use them, you should be able to get a decent idea by just looking at the job tests added in #28625, or the nuke ops test that was updated in #28549
@ElectroJr ElectroJr added Difficulty: 2-Medium A good amount of codebase knowledge required. Issue: Test coverage This issue relates to a need for more integration testing. labels Jun 5, 2024
@github-actions github-actions bot added the Status: Untriaged Somebody go through and give this appropriate labels label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: 2-Medium A good amount of codebase knowledge required. Issue: Test coverage This issue relates to a need for more integration testing. Status: Untriaged Somebody go through and give this appropriate labels
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ElectroJr