Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Job preference tests #28625

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

ElectroJr
Copy link
Member

@ElectroJr ElectroJr commented Jun 5, 2024

The main point of this PR is to add several job related tests that check that preferences, weights, and priorities work. See JobTest.cs

Other Changes:

  • Adds methods to TestPair.Helpers.cs for modifying a job preferences
  • Test pairs now automatically reset any modified preferences when returning to the pool.
  • Replaced various strings with ProtoId<JobPrototype> or ProtoId<AntagPrototype>.
  • Fixes some HumanoidCharacterProfile methods to ensure that only a single job can be set to high priority
  • Changed StationJobsComponent:
    • The MidRoundTotalJobs, OverflowJobs and RoundStartJobList fields are no longer datafields, as they can just be inferred from the SetupAvailableJobs field.
    • The "JobList" dictionary now uses int? instead of uint? values. They're still always positive, it just reduced the amount of annoying casts.

@github-actions github-actions bot added S: Needs Review Indicates an item that requires new reviews. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design. Changes: Map Should be reviewed or fixed by people who are knowledgeable with mapping. labels Jun 5, 2024
@metalgearsloth metalgearsloth merged commit adeed70 into space-wizards:master Jun 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Should be reviewed or fixed by people who are knowledgeable with mapping. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design. S: Needs Review Indicates an item that requires new reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants