Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .vscode from version control #29285

Closed
diraven opened this issue Jun 21, 2024 · 4 comments
Closed

Remove .vscode from version control #29285

diraven opened this issue Jun 21, 2024 · 4 comments
Labels
Status: Untriaged Somebody go through and give this appropriate labels

Comments

@diraven
Copy link
Contributor

diraven commented Jun 21, 2024

Description

.vscode settings being in VCS forces everybody to use them and prevents customization. Workspace settings override user settings. Which means you effectively can't customize workspace settings for this project at all without your changes ending up in VCS, which is very likely an undesirable outcome.

I believe the right thing to do here would be:

  • Renaming .vscode to something like sample.vscode in VCS and ignoring .vscode itself.
  • Possibly also adding automatic copying of sample.vscode to .vscode if .vscode does not exist into RUN_THIS.py.

That way we can still distribute configuration changes/templates if need be with devs retaining the ability to change their local workspace settings including settings.json, tasks.json and launch.json.

@github-actions github-actions bot added the Status: Untriaged Somebody go through and give this appropriate labels label Jun 21, 2024
@diraven
Copy link
Contributor Author

diraven commented Jun 21, 2024

I'll make a PR for it later if there are no hard objections to this.

@PJB3005
Copy link
Member

PJB3005 commented Jun 21, 2024

Doesn't VSCode have a "default workspace settings" system exactly for this purpose?

@osjarw
Copy link
Contributor

osjarw commented Jun 21, 2024

Not an expert on these particular settings, but stuff like formatter settings definitely should belong in the workspace settings.

@diraven
Copy link
Contributor Author

diraven commented Jun 22, 2024

Doesn't VSCode have a "default workspace settings" system exactly for this purpose?

Didn't find such functionality in VSCode. Only thing I found is this ancient issue, which was not worked on yet it seems. You got a link?

Not an expert on these particular settings, but stuff like formatter settings definitely should belong in the workspace settings.

It probably should. But that's a bit out of scope for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Untriaged Somebody go through and give this appropriate labels
Projects
None yet
Development

No branches or pull requests

3 participants