Oldchat #11913

vulppine · 2022-10-14T08:04:15Z

About the PR

SS13 style chat. This includes a new layout for the HUD, called 'Separated', which is similar to Space Station 13's UI layout. This also includes a new setting to set the width of the viewport, so that a user can make it more square, or more wider - the minimum size is 1:1, and the maximum size is the current ratio of SS14's viewport.

This also fixes a chat focusing bug seen when a player is in the lobby, and tries to focus on the chatbox using hotkeys.

Screenshots

Changelog

🆑

add: The classic Space Station 13 style HUD layout has been ported to Space Station 14! Enjoy having your chat in its own separate section of game HUD!

…separated chat game screen

oldchat is currently not selectable

…rated chat game screen's chat portion

github-actions · 2022-10-16T15:46:40Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

# Conflicts: # Content.Client/Lobby/LobbyState.cs # Content.Client/UserInterface/Systems/Chat/ChatUIController.cs

ike709 · 2022-10-17T19:59:52Z

I really think that the top bar of buttons should be reversed, so that Esc is next to the top right corner instead of just kind of in the middle of the screen. Otherwise, incredibly based.

mirrorcult · 2022-10-17T21:22:16Z

NRE when opening client

[FATL] unhandled: System.NullReferenceException: Object reference not set to an instance of an object.
   at Robust.Shared.GameObjects.EntitySystemManager.GetEntitySystem[T]() in K:\github.com\mirrorcult\space-station-14\RobustToolbox\Robust.Shared\GameObjects\EntitySystemManager.cs:line 65
   at Robust.Shared.GameObjects.EntitySystem.Get[T]() in K:\github.com\mirrorcult\space-station-14\RobustToolbox\Robust.Shared\GameObjects\EntitySystem.cs:line 143
   at Content.Client.UserInterface.Systems.Chat.Widgets.ChatBox.OnTextChanged(LineEditEventArgs args) in K:\github.com\mirrorcult\space-station-14\Content.Client\UserInterface\Systems\Chat\Widgets\ChatBox.xaml.cs:line 200

mirrorcult · 2022-10-17T21:24:07Z

(on startup, i hadn't typed anything)

mirrorcult · 2022-10-17T21:26:39Z

ok that might be a master bug actually (edit it was)

vulppine · 2022-10-17T21:29:57Z

ok that might be a master bug actually (edit it was)

i moved that system get into the controller anyways since there's already a dependency for it

vulppine · 2022-10-17T21:33:30Z

I really think that the top bar of buttons should be reversed, so that Esc is next to the top right corner instead of just kind of in the middle of the screen. Otherwise, incredibly based.

the layout of the menu bar buttons isn't dynamic and would require another separate widget to be implemented in order to achieve this (not necessarily a bad idea, still)

mirrorcult

scaling, cvar stuff all works fine, no bugs ingame afaict

Content.Client/Gameplay/GameplayState.cs

mirrorcult · 2022-10-17T21:14:09Z

Content.Client/Gameplay/GameplayState.cs

+            // TODO: This could just be like, the equivalent of an event or something
+            _ghostController.UpdateGui();
+            _actionController.RegisterActionContainer();
+            _alertsController.SyncAlerts();
+            _hotbarController.ReloadHotbar();


can this not just be an action/c# event that gets invoked and which all of these subscribe to, seems to be a pattern elsewhere in UI

state startup happens before the call that occurs when a state is entered, so i can't use that unfortunately - and since the state entered call also gives controllers a reference to the current state, it ends up being that i have to manually do this

well thats annoying

i can try to do one thing though, and that's just move all this to its own controller

actually could you do this in a separate UI controller made for this purpose on the state enter

ok github didnt load that comment glad we had the same idea

mirrorcult · 2022-10-17T21:35:46Z

i agree w ike on the order of the buttons but doesnt need to be done in this PR imo

vulppine added 12 commits October 13, 2022 13:39

attempt at moving MainViewport to UIWidget

49fe225

oldchat (prototype)

1073541

separate oldchat and default ss14 HUD into their own files

a991d65

restores original default game screen logic and adds that logic into …

10bf322

…separated chat game screen

hand reloading, several tweaks to port oldchat to main ss14 branch

50ac003

oldchat is currently not selectable

screen type cvar, gameplay state screen reloading/loading

264f78b

reload screen on ui layout cvar change

4349c98

fixes up basic reloading (HUD switching is still very bad)

4e453a2

some UI widget reloading for main UI screen switching

d4c4c11

alert sync on screen change

d6fb89a

inventory reload

1c81377

hotbar margin fix

91b8c3f

github-actions bot added the Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design label Oct 14, 2022

vulppine added 4 commits October 14, 2022 01:31

chat bubbles above viewport

09468a0

whoops

eb02824

fixes ordering of speech bubble root

2b4ed85

should fix the chat focus issue (at least in-game, not lobby yet)

fb027f0

Stealthbomber16 mentioned this pull request Oct 14, 2022

Inconsistency with radio chat channels #11920

Closed

vulppine added 11 commits October 14, 2022 12:07

should fix up the lobby/game chat focus

c508dba

fixes chat for lobby, turns lobby into a UI state

958e881

viewport UI controller

dcbfc6e

viewport ratio selection

022218e

whoops

8dad52f

adds the /tg/ widescreen ratio

3c2b7eb

removes warning from inventory UI controller, adds background to sepa…

7f2259e

…rated chat game screen's chat portion

menu button reload

8112881

unload menu buttons only from gameplay state shutdown

1f1cf41

bugfix

79a4a9a

character button fix

a5a48c1

Zumorica added the Holy Shit This is real important!! label Oct 15, 2022

github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Oct 16, 2022

ElectroJr mentioned this pull request Oct 17, 2022

Fix chat popup rendering #11987

Merged

vulppine added 2 commits October 17, 2022 01:52

adds config options for viewport width/UI layout

6a10c44

Merge branch 'upstream' into oldchat

bf6a672

# Conflicts: # Content.Client/Lobby/LobbyState.cs # Content.Client/UserInterface/Systems/Chat/ChatUIController.cs

vulppine marked this pull request as ready for review October 17, 2022 18:29

vulppine requested review from RemieRichards, PaulRitter and ElectroJr as code owners October 17, 2022 18:29

github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged. and removed Merge Conflict This PR currently has conflicts that need to be addressed. labels Oct 17, 2022

moonheart08 approved these changes Oct 17, 2022

View reviewed changes

variable naming changes, get or null instead of get to avoid exceptions

338173f

moves entity system get into controller

871cbc7

mirrorcult requested changes Oct 17, 2022

View reviewed changes

mirrorcult approved these changes Oct 17, 2022

View reviewed changes

moonheart08 merged commit a3dafd8 into space-wizards:master Oct 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Oldchat #11913

Oldchat #11913

vulppine commented Oct 14, 2022 •

edited

github-actions bot commented Oct 16, 2022

ike709 commented Oct 17, 2022 •

edited

mirrorcult commented Oct 17, 2022

mirrorcult commented Oct 17, 2022

mirrorcult commented Oct 17, 2022 •

edited

vulppine commented Oct 17, 2022

vulppine commented Oct 17, 2022

mirrorcult left a comment

mirrorcult Oct 17, 2022

vulppine Oct 17, 2022

mirrorcult Oct 17, 2022

vulppine Oct 17, 2022

mirrorcult Oct 17, 2022

mirrorcult Oct 17, 2022

mirrorcult commented Oct 17, 2022

Oldchat #11913

Oldchat #11913

Conversation

vulppine commented Oct 14, 2022 • edited

About the PR

github-actions bot commented Oct 16, 2022

ike709 commented Oct 17, 2022 • edited

mirrorcult commented Oct 17, 2022

mirrorcult commented Oct 17, 2022

mirrorcult commented Oct 17, 2022 • edited

vulppine commented Oct 17, 2022

vulppine commented Oct 17, 2022

mirrorcult left a comment

Choose a reason for hiding this comment

mirrorcult Oct 17, 2022

Choose a reason for hiding this comment

vulppine Oct 17, 2022

Choose a reason for hiding this comment

mirrorcult Oct 17, 2022

Choose a reason for hiding this comment

vulppine Oct 17, 2022

Choose a reason for hiding this comment

mirrorcult Oct 17, 2022

Choose a reason for hiding this comment

mirrorcult Oct 17, 2022

Choose a reason for hiding this comment

mirrorcult commented Oct 17, 2022

vulppine commented Oct 14, 2022 •

edited

ike709 commented Oct 17, 2022 •

edited

mirrorcult commented Oct 17, 2022 •

edited