New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify meta.json files #13035
Minify meta.json files #13035
Conversation
These were always supposed to be minified we just got lazy.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
i really hate it if we're doing this, these are way harder to edit and rsiedit doesn't emit them minified anymore (+ people are unlikely to want to do if they're not using rsiedit) so it's just going to pile up again what is the motivation, just reduced line count? i don't really think it matters |
If we do intend these to be hand editable now then it should just be yml like everything else. |
Minified JSONs is a setting in RSIEdit, it could be enabled by default. |
We've established multiple times they should be YML. |
Please no I don't want to have slow-ass YAML loading even more. Also YAML libraries in e.g. Python are all garbage compared to If you wanna edit minified JSON files just install something like this into VSCode. One command to format the JSON (so it's readable) and another to pack it back down when you're done. Also if we don't wanna minify the JSON at least change the editorconfig to match the current style we have (2 space indents). Also merge #12997 first please I beg |
when |
Texture folder size goes down 1.5MB There's existing tooling around this like PJB said so I don't understand why pressing a keybind to unminify and another to minify is a big deal if you really need it which I was doing in #13027 We already have much bigger workflow difficulties than this that also don't give us free performance and can't be fixed with 1 button. |
The maintainer council has deemed this as cringe as it would make things harder to edit and review for no real gain |
These were always supposed to be minified we just got lazy. Also a handful of files were saved as utf-8 bom which I have updated to utf-8 (all of the cigar files + a handful of othe rones).
I also included the script I used to do it + checked it ingame.