New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moves steak cooking to use construction graphs, new temperature construction graph step #13219
moves steak cooking to use construction graphs, new temperature construction graph step #13219
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…eakettle/space-station-14 into temperature-change-step
Thank you for this PR! It's an important step for a decent cooking & food system. Just a thing though: right now the cooking wiki is automatically updated/built based on the recipes file you removed the recipes from. I think the build script should be updated somehow to support loading construction graph based food recipes. Unless we want to remove the wiki page in favor of an ingame solution similar to the crafting menu. Speaking of the crafting menu, will the recipes you made show up there? I think the menu is hard to navigate as it is already, the idea of also having all food recipes in there as well does not sound pleasant. Last nitpick, the changelog you made seems more for coders rather than players. I don't think players would care about construction graphs, so i think the first changelog entry can be removed (can a maintainer confirm this?) |
The script is third party, it's not their responsibility to fix. |
Closes #13084 |
does this work with microwaving right now |
Microwaves heat up things inside of it but only to a certain point. This may make it so you can't cook steak in microwaves, but thats probably fine. |
Would it be possible at all to write down the construction graph once and have it apply to all meats? Also, shouldn't the temperature be a lot higher? 305 K is 32 C, so less than (human) body temperature. |
Probably if you make the graph just “CookedMeat” and have the step take a tag for anything with RawMeat. Steak is an outlier in my mind since it has different levels of done-ness. |
Mfw all my meat gets cooked on a particularly hot day |
…ruction graph step (space-wizards#13219)
About the PR
added new temperature step to construction graph
moved several meat based recipes to this system with a simple graph of just heat up to 305K and it becomes the cooked version
removed plates on these because we should have a separate system to allow for any food being plated without it actually changing the food item (i.e. a cooked steak should be the same entity with or without a plate)
this means that the steaks can be cooked by any source, i.e. a fire will cook raw meat into steaks
currently there's no step for making them into a burned mess but this would be a quick change if it's requested, it's just an extra node where if the temperature goes past a certain point, it turns into a burned mess
Changelog
🆑