Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readmin enables Debug Coordinates in F3 overlay #25063

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Readmin enables Debug Coordinates in F3 overlay #25063

merged 2 commits into from
Mar 6, 2024

Conversation

Errant-4
Copy link
Contributor

@Errant-4 Errant-4 commented Feb 8, 2024 •
edited

About the PR

Currently, removing your admin status hides debug coordinates from the overlay, but restoring admin status does not bring them back. Readmin will now automatically enable Debug Coordinates on F3 overlay
fixes #24925

Technical details

The line that originally re-enabled the debug coordinates on the overlay upon readmin was removed because it ran every frame, and it turns out that was a bad idea. (It made it impossible for admins to manually hide that part of the F3 overlay)

It was already possible to enable the coordinates while admin with /monitor Coords, but now it will happen automatically upon /readmin

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
馃啈 Errant
ADMIN:

  • fix: Debug coordinates are now automatically enabled on the F3 overlay upon readmin.

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Feb 8, 2024
moonheart08
moonheart08 suggested changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@moonheart08 moonheart08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we properly fix the debug monitor API to allow blacklisting monitors instead of continuing to build on my shitty hack.

@Errant-4
Copy link
Contributor Author

Can we properly fix the debug monitor API to allow blacklisting monitors instead of continuing to build on my shitty hack.

That's... fair, though I'm not sure how much more complicated that will be. I'll look into it

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Feb 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Mar 5, 2024
@metalgearsloth
Copy link
Contributor

This keeps messing with me locally and I'd rather have something.

@metalgearsloth metalgearsloth merged commit 46f6799 into space-wizards:master Mar 6, 2024
10 checks passed
Hiucko added a commit to Hiucko/hiucko-station that referenced this pull request Mar 7, 2024
@Hiucko @Menshin
@QuietlyWhisper @PJBot @DuskyJay @MACMAN2003 @deepdarkdepths @lzk228 @Tayrtahn @PJB3005 @ps3moira @Froffy025 @Ko4ergaPunk @notquitehadouken @Ilya246 @JustArt1m @Errant-4 @metalgearsloth @Brandon-Huu @Kadeo64 @exincore @Dutch-VanDerLinde @slarticodefast @Plykiya @Decortex @shampunj
UPDATE (#6)
22d6c35 
* Enforce Space Heater max/min temperatures server side (space-wizards#25835)

Actually enforce max/min temperatures server side

* the bladed flatcap (space-wizards#25780)

* Automatic changelog update

* Add nutribricks to other survival boxes (space-wizards#25749)

* Clockwork structures and furniture (space-wizards#24673)

* sprites

something something strength and certainty of steel (except this is brass)

* test1

* commas it was commas

* commas and brackets

* LET THERE BE BRASS

* brass-glass-etc-windows-thindows-floors-lattice

* ALL THE STRUCTURES!!

"Which structures did you add?"
"all."

* buyable brass

and on the first day the quartermaster said "let there be brass" and all the cargo techs stopped inve$ting in awe

* Update windoor.yml

i forgor 馃拃

* Update tiles.ftl

* i hate random capital letters

* linter fix 1

whew, thank god for linters

* fix 2

* maybe this

shot in the dark, idk what the hell i'm doing hopefully this fixes it?

* fix attempt 1

weather to true, maybe the thingy got confused?

* remove clockwork lattice

it's fixed the test fail... but at what cost?

* changes 1

* fix clockwork windoor

* FLOORS

HAHAHA LET THERE BE FLOORS

* try linter fix 1

i love linters they find things i'd never catch myself

* tweaks fixes 1

fixes merge conflict and does more stuff part two later because i'm tired

* tweaks fixes 2

i should probably do this stuff during the day when i have more energy but eh

* Update assembly.yml

* Update chairs.yml

* fix door sprites

somehow the deny_unlit was broken for all the clockwork doors

* fix glass.yml

* Automatic changelog update

* Adds paramedic cap to the uniform printer (space-wizards#25861)

Update lathe+clothing.yml

* Automatic changelog update

* Fixes glowsticks being unable to be inserted into trashbags (space-wizards#25863)

Glowstick now garbo

* Allow livestock and artifact crate to go under plastic flaps (space-wizards#25862)

* Add prediction to hand labeler labels (space-wizards#25869)

Added prediction to labels

* Automatic changelog update

* Paper save button, back to ctrl+enter save. (space-wizards#25870)

* Revert "Change keybindings for paper (space-wizards#25853)"

This reverts commit 4b56996.

* Add a save button to the paper editing UI instead.

* Separate Certain Walls (space-wizards#25674)

Separate Walls

* Automatic changelog update

* Add water to water tiles. (space-wizards#25825)

* update

* rename tank to pool. bigger arbitrary #. remove bad copy paste part.

* Automatic changelog update

* Post light update (space-wizards#25814)

* penis

* done

* Update wideswing rotations (space-wizards#25868)

* Added appropriate wideAnimationRotation fields to items that needed it

* Modified some wideAnimationRotation

* Automatic changelog update

* buff gas leak event (space-wizards#25864)

the fog is coming

* New cloth & hair (space-wizards#25772)

* Clothing sprites & meta

* Changing prototypes & sprites

Rename sprites folder, edit prototypes and meta

* Hair_sprites_&_prototype

Add hair sprites and change prototype

* Update meta.json

* Rename added hair

* Revert "Changing prototypes & sprites"

This reverts commit 801cadb.

* Revert "Clothing sprites & meta"

This reverts commit 7344216.

* Automatic changelog update

* Automatic changelog update

* Readmin enables Debug Coordinates in F3 overlay (space-wizards#25063)

readmin debugcoords

* Fix pod launch offset (space-wizards#25855)

Was too lazy to fix and forgot.

* Automatic changelog update

* Add SharedPopupSystem.PopupPredicted (space-wizards#25811)

* Added SharedPopupSystem.PopupPredicted

* Documentation improvement

* adds barber scissors to hristov bundle (space-wizards#25695)

bald update

Co-authored-by: Kadeo64 <108914677+Kadeo64@users.noreply.github.com>

* Automatic changelog update

* Remove all obsolete BatteryComponent method calls (space-wizards#25871)

Removed all obsolete, non-ECS method calls to BatteryComponent

* Hotfix for errors in handheld lights and radio jammers (space-wizards#25880)

* Make flasks fit in dispensers again (space-wizards#25883)

Added FitsInDispenser to FlaskBase

* Automatic changelog update

* fix(emag): Emagging a lock properly unlocks the component (space-wizards#25858)

* fix(emag): Emagging a lock properly unlocks the component

Fixes space-wizards#24860

* fix(emag): Emagging a lock no longer duplicates the unlock sound

* Monkeys can wear all types of masks, not just breath/gas masks (space-wizards#25816)

* clown mask real

* Update masks.yml

* Fix datafield name (space-wizards#25651)

* Fix: Syringe requires hands and breaks on change now (space-wizards#25896)

Syringe requires hands and breaks on change

Co-authored-by: Plykiya <plykiya@protonmail.com>

* ATV resprite (space-wizards#25885)

* Delete Resources/Textures/Objects/Vehicles/atv.rsi/vehicle.png

* Add files via upload

* Delete Resources/Textures/Objects/Vehicles/atv.rsi/Vehicle.png.png

* Add files via upload

* Update meta.json

* Update meta.json

* .

* Fix body bags sliding under doors (space-wizards#25325)

---------

Co-authored-by: Menshin <Menshin@users.noreply.github.com>
Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: Jay <67732946+DuskyJay@users.noreply.github.com>
Co-authored-by: MACMAN2003 <macman2003c@gmail.com>
Co-authored-by: deepdarkdepths <155149356+deepdarkdepths@users.noreply.github.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Co-authored-by: Ps3Moira <113228053+ps3moira@users.noreply.github.com>
Co-authored-by: Froffy025 <78222136+Froffy025@users.noreply.github.com>
Co-authored-by: Ko4ergaPunk <62609550+Ko4ergaPunk@users.noreply.github.com>
Co-authored-by: I.K <45953835+notquitehadouken@users.noreply.github.com>
Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com>
Co-authored-by: 袗褉褌 <123451459+JustArt1m@users.noreply.github.com>
Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Brandon Hu <103440971+Brandon-Huu@users.noreply.github.com>
Co-authored-by: Kadeo64 <108914677+Kadeo64@users.noreply.github.com>
Co-authored-by: exincore <me@exin.xyz>
Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com>
Co-authored-by: Plykiya <plykiya@protonmail.com>
Co-authored-by: Decortex <122426300+Decortex@users.noreply.github.com>
Co-authored-by: shamp <140359015+shampunj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonheart08 moonheart08 moonheart08 requested changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@Chief-Engineer Chief-Engineer Awaiting requested review from Chief-Engineer Chief-Engineer is a code owner

Assignees
No one assigned
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F3 Doesnt show grid, map, or coords for aGhosts
3 participants
@Errant-4 @metalgearsloth @moonheart08