Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tippy, the helpful hint clown! #26767

Merged

Conversation

SlamBamActionman
Copy link
Contributor

@SlamBamActionman SlamBamActionman commented Apr 6, 2024

About the PR

This PR adds Tippy the clown, a humorous command that allows admins to broadcast messages to players via a clown walking onto the screen. It's possible to customize the Tippy tip to target a specific player, and set Tippy's sprite to look like any entity.

Tippy has a 1% chance to spawn instead of a normal chat gameplay tip.

/tippy <player session | broadcast> <message> [entity prototype] [speak time] [animate time] [waddle] is an admin command to spawn Tippy.
/tip is an admin command to generate a random chat gameplay tip.

Why / Balance

Tippy is a charming little fella and adds a bit of levity. Mostly an admeme thing, but when he (rarely) randomly appears it'll be a fun time for all.

Technical details

This PR utilizes the code from #26112 with some minor cleanup to remove April's Fools functionality.

Media

2024-04-08.22-39-23.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

no cl, lots of fun!

@github-actions github-actions bot added Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design labels Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

RSI Diff Bot; head commit f883fd4 merging into 813a0b7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Tips/tippy.rsi

State Old New Status
down Added
left Added
right Added

Edit: diff updated after f883fd4

@SlamBamActionman
Copy link
Contributor Author

There is a minor visual bug where the speech bubble appears for one frame in the wrong location before being repositioned and I filled with text. It's not very noticable but it's there, so if anyone can suggest a fix I'm all ears.

Copy link
Contributor

@Simyon264 Simyon264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tippy👍

Content.Client/Tips/ClippyUIController.cs Outdated Show resolved Hide resolved
Content.Client/Tips/ClippyUIController.cs Outdated Show resolved Hide resolved
Content.Server/Tips/TipsSystem.cs Outdated Show resolved Hide resolved
Content.Server/Tips/TipsSystem.cs Outdated Show resolved Hide resolved
Content.Server/Tips/TipsSystem.cs Outdated Show resolved Hide resolved
Content.Server/Tips/TipsSystem.cs Outdated Show resolved Hide resolved
Content.Server/Tips/TipsSystem.cs Outdated Show resolved Hide resolved
Content.Client/Tips/ClippyUIController.cs Outdated Show resolved Hide resolved
Content.Client/Tips/ClippyUIController.cs Outdated Show resolved Hide resolved
@beck-thompson
Copy link
Contributor

Could you show a video? Sounds super fun 😆

…_clippy command, made it easier to target a specific player
@SlamBamActionman
Copy link
Contributor Author

  • All references to Clippy have been removed
  • Localization strings have been added
  • Command has autocomplete and targeting a specific player is now easier
  • local_clippy has been removed (didn't really serve much of a point)

I didn't change it from RegisterCommand into LocalizedCommand since it'd require changing the inheritance; let me know if it's a hard requirement. Also, video is up in the description.

@SlamBamActionman SlamBamActionman marked this pull request as ready for review April 8, 2024 20:47
@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Apr 8, 2024
@SlamBamActionman
Copy link
Contributor Author

Test fail appears unrelated to PR.

@brainfood1183
Copy link
Contributor

brainfood1183 commented Apr 9, 2024

Now admins can make Jonky The Unhelpful Hint-Cluwne

@dvir001
Copy link
Contributor

dvir001 commented Apr 15, 2024

1% is a lot for this.
This should be a 1 to 10000 or even 100000

@superjj18
Copy link
Contributor

superjj18 commented Apr 15, 2024

1% is a lot for this. This should be a 1 to 10000 or even 100000

That’s insane, you may as well just not add it at all other than for admins

We must calculate how many tips per day per server, and from that we can extrapolate tippy’s per day. :trollface:

@beck-thompson
Copy link
Contributor

1% might be a little much but you can easily just change it to like .5% or .25%. 1 / 100000 is so small you might as well remove it!

@SlamBamActionman
Copy link
Contributor Author

SlamBamActionman commented Apr 15, 2024

Unless a maintainer chimes in with a percentage, this can just be merged to see how oppressive it is and then be adjusted as necessary. It's a CCVar so editing the value isn't particularly difficult.

@mirrorcult
Copy link
Contributor

1% is fine lol its just tippy

@mirrorcult mirrorcult merged commit 373c368 into space-wizards:master Apr 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants