Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower max firestacks to 10, refactor flammable #27159

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

QuietlyWhisper
Copy link
Contributor

@QuietlyWhisper QuietlyWhisper commented Apr 20, 2024

About the PR

  • might fix Admin fire smite is now too deadly聽#23963
  • Lowers max firestacks from 20 > 10
  • Uncaps the damage limit of 5 fire stacks
  • Lowers heat damage from fire stacks to be the same as before at most
    • Less fire stacks will do less damage however, as the fire stacks go down.

Why / Balance

#27159 (comment)

Changelog

馃啈 Whisper

  • tweak: Fire stack limit reduced from 20 to 10. Fire transfers will be less effective, and fires will not last as long.

@github-actions github-actions bot added the Status: Needs Review This PR requires new reviews before it can be merged. label Apr 20, 2024
@deltanedas
Copy link
Contributor

i think mass scaling is better to fix liltenhead ops

@deltanedas
Copy link
Contributor

also damage was capped at 5 firestacks, any more than that just makes it last longer

@QuietlyWhisper
Copy link
Contributor Author

also damage was capped at 5 firestacks, any more than that just makes it last longer

I see that now, and that's a little weird

@deltanedas
Copy link
Contributor

still dont think this is needed:

  • if you are aware you are on fire you can stop drop and roll
  • if you are dead someone can splash water on you
  • if someone wants to burn you to a crisp a single 20 stack wont do it with most armour so theyll still have to go for seconds anyway

@QuietlyWhisper
Copy link
Contributor Author

QuietlyWhisper commented Apr 20, 2024

I'm going to uncap damage since the cap is an arbitrary number and reduce heat damage to keep the old scaling of 5 being the max damage, 15/s

And then from there we can see what needs to be increased

@QuietlyWhisper
Copy link
Contributor Author

QuietlyWhisper commented Apr 20, 2024

Ok so at the time of writing this comment, after these changes:

  • a max stack fire burns out at 1471 heat, which would mean armored people do not burn to ash but unarmored are nearly ashed. (This assumes you dont make any attempts to put out the fire)
    • Antagonists could ash people still by simply adding more fuel at least once while the fire fades
    • You'd just have to remove someone's armor if you wanted to do that I suppose, you wouldnt burn a body in a firesuit after all.
  • In theory, as long as you're in a safe place (no overheated atmos) and have taken no other sources of heat damage, you shouldn't burn to ash if you're a regular crewmember.
  • It should also be easy to keep up the max fire damage with fuel since the limit is a lot lower.
  • you no longer burn to death if you drop and roll at max stacks, so saving yourself is possible, but you will still crit in most cases.
  • people with 50% heat resistance will get out with about 60 heat damage if they drop and roll as soon as possible

Another balance value I didn't touch is the ash threshhold, which is still 1500

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label Apr 22, 2024
# Conflicts:
#	Content.Server/Atmos/EntitySystems/FlammableSystem.cs
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label Apr 22, 2024
@metalgearsloth metalgearsloth merged commit eee056e into space-wizards:master Apr 23, 2024
11 checks passed
@QuietlyWhisper QuietlyWhisper deleted the tweak-firestacks branch April 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This PR requires new reviews before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin fire smite is now too deadly
3 participants