Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GenericAntag completely #28218

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented May 23, 2024

About the PR

depends on:

fixes #28212

Why / Balance

its no longer needed

Technical details

🕯️ 🕯️ 🕯️ 🕯️ 🕯️ rest in piss

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

GenericAntagRuleComponent and GenericAntagComponent have been deleted in favour of AntagObjectivesComponent and having the rule spawn the antag rather than the other way around. to have a rule easily show up in roundend summary just set agentName on AntagSelectionComponent like before.

Changelog
no genericantag no fun

@metalgearsloth
Copy link
Contributor

he cookin

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR currently has conflicts that need to be addressed. label May 25, 2024
@github-actions github-actions bot removed the Merge Conflict This PR currently has conflicts that need to be addressed. label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenericAntag should be nuked
2 participants