Fix firelock prediction issues with periodic pulses of closing lights #28227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason this function was setting a time for the next state which was triggering the door system to try to close the firelock. This does not happen serverside because the function only fires from an event called clientside apparently. It appears to be an attempt to stop firelocks from closing instantly that did not function properly, and I cannot discern any other purpose. As such I have removed it.
This became redundant with commit 439a87f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28230
About the PR
This pr fixes firelocks having random pulses of closing lights which were mispredicts. This would randomly start happening and would happen every 3 seconds due to the set cooldown duration.
Technical details
From what I understand the functions existed in order to prevent doors from closing constantly due to atmos alarms going off making it impossible to cross with crowbars. This is rendered redundant by the check in the EmergencyPressureStop() function in the C.S.FirelockSystem which ensures that a firelock will not auto close for at least 2 seconds after being pried. Due to an oversight in #26582, a part of the handling was transferred to shared while some remained in server due to a power check. This caused mispredicts to happen in some cases which would repeat every 3 seconds.
Media
Breaking changes
N/A
Changelog
馃啈