Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace iron with hyper + routerify #112

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Replace iron with hyper + routerify #112

wants to merge 4 commits into from

Conversation

rnestler
Copy link
Member

This is just a very raw POC to replace iron by directly using hyper with routerify. The simple static version produces some JSON, but there would obviously still a lot of work needed.

I want to clarify a few things first:

  • Are we OK with this stack?
  • Are we OK with moving everything to async? This also needs changes for the users of the library.

Checklist

  • Tests added if applicable
  • README updated if applicable
  • CHANGELOG updated if applicable
  • If a commit includes a breaking change, include the string [breaking-change] somewhere in the commit message

@rnestler rnestler requested review from dbrgn and g5pw August 12, 2022 12:22
@dbrgn
Copy link
Collaborator

dbrgn commented Aug 15, 2022

Are we OK with this stack?

I think using hyper directly is a valid choice for a small application. The tricky thing might be clean handling of resources, i.e. the Redis connection pool.

Alternatives that would be worthwhile to check out: I'd say axum, warp or actix-web.

Are we OK with moving everything to async? This also needs changes for the users of the library.

Yeah, we just bump the major version. I think async is here to stay.

@rnestler rnestler force-pushed the remove-iron branch 2 times, most recently from 31020eb to 7f631aa Compare August 21, 2022 14:46
@dbrgn
Copy link
Collaborator

dbrgn commented Nov 4, 2022

@rnestler what's the status on this? 🙂 Do you plan to continue the work, or should I try to pick up?

@rnestler
Copy link
Member Author

rnestler commented Nov 8, 2022

@dbrgn Yes I plan to continue on it 🙂 But it might take some time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants