Set default magick limits #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 85 85
Lines 1268 1268
Branches 181 181
=======================================
Hits 1237 1237
Misses 30 30
Partials 1 1Continue to review full report at Codecov.
|
ericwenn
requested changes
Nov 13, 2018
There was a problem hiding this comment.
Nice!
According to Docker documentation each ENV instruction creates a new layer in the image so we should declare all of this variables in one command (see https://stackoverflow.com/a/45529293/1642401).
ericwenn
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagemagick defaults in policy.xml are not enabled, I've added so we enable relevant settings through environment as a default.
http://www.imagemagick.org/script/resources.php#environment
related: #172