Remove API to update poet servers #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
approved these changes
Oct 31, 2023
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 31, 2023
## Motivation Remove the API to live-update poet servers ## Changes - updated the api dep to spacemeshos/api#280, merge after this - removed relevant code - updated the system tests using this API - fixed a problem in system tests where multiple `smesher-0` nodes are created all of which but 1 are destroyed - I believe this causes recent flakiness of systests. ## Test Plan Existing tests pass
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 31, 2023
## Motivation Remove the API to live-update poet servers ## Changes - updated the api dep to spacemeshos/api#280, merge after this - removed relevant code - updated the system tests using this API - fixed a problem in system tests where multiple `smesher-0` nodes are created all of which but 1 are destroyed - I believe this causes recent flakiness of systests. ## Test Plan Existing tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the API to update poet servers as there's no good use case to keep it and it would require additional work to make it reliable and safe to use.