[Merged by Bors] - Removed API to update poet servers from SmesherService #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #5209 +/- ##
=========================================
- Coverage 78.1% 78.0% -0.1%
=========================================
Files 264 264
Lines 31825 31802 -23
=========================================
- Hits 24870 24831 -39
- Misses 5454 5474 +20
+ Partials 1501 1497 -4
|
|
bors try |
fasmat
approved these changes
Oct 31, 2023
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
## Motivation Remove the API to live-update poet servers ## Changes - updated the api dep to spacemeshos/api#280, merge after this - removed relevant code - updated the system tests using this API - fixed a problem in system tests where multiple `smesher-0` nodes are created all of which but 1 are destroyed - I believe this causes recent flakiness of systests. ## Test Plan Existing tests pass
|
Build failed:
|
|
Bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
## Motivation Remove the API to live-update poet servers ## Changes - updated the api dep to spacemeshos/api#280, merge after this - removed relevant code - updated the system tests using this API - fixed a problem in system tests where multiple `smesher-0` nodes are created all of which but 1 are destroyed - I believe this causes recent flakiness of systests. ## Test Plan Existing tests pass
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
Clean up leftovers missed in #5209.
bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
Clean up leftovers missed in #5209.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove the API to live-update poet servers
Changes
smesher-0nodes are created all of which but 1 are destroyed - I believe this causes recent flakiness of systests.Test Plan
Existing tests pass