v2alpha1: Add sort_order field to List requests #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
reviewed
Jun 19, 2024
spacemesh/v2alpha1/layer.proto
Outdated
| @@ -24,6 +25,7 @@ message LayerRequest { | |||
| uint32 end_layer = 2; | |||
| uint64 offset = 3; // adjusts the starting point for data | |||
| uint64 limit = 4; // specifies max number of items to fetch | |||
| optional SortOrder sort_order = 5; // specifies the sort order (default is ASC) | |||
There was a problem hiding this comment.
Do you need the optional keyword if the default is the 0-value enum variant anyway (ASC)? Btw, I'd expect that the default (when not set) is to not sort at all. Wdyt?
poszu
reviewed
Jun 19, 2024
Comment on lines
+18
to
+21
| ASC = 0; | ||
| DESC = 1; | ||
| } |
There was a problem hiding this comment.
Two questions:
- what about "don't sort" variant? It could save some cycles when sorting is not needed.
- does the default need to be "sorted"?
There was a problem hiding this comment.
We can add third option which is "don't sort" but the current implementation sorts in ascending order, and I don't want to break existing integrations for others.
# Conflicts: # release/go/spacemesh/v2alpha1/v2alpha1.pb.go # spacemesh/v2alpha1/v2alpha1.proto
poszu
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sort_order field (enum ASC/DESC) to tx, layer and reward List requests