Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Make sure new ATXs are being properly reported after block builder refactoring #2116

Closed
lrettig opened this issue Aug 11, 2020 · 1 comment
Closed

API: Make sure new ATXs are being properly reported after block builder refactoring #2116

lrettig opened this issue Aug 11, 2020 · 1 comment
Assignees
@lrettig
Projects
API

Comments

@lrettig
Copy link
Member

lrettig commented Aug 11, 2020 •
edited

Need to account for changes in efa7538 / #2011:

go-spacemesh/activation/atxdb.go

Line 763 in efa7538

events.Publish(events.ValidAtx{ID: atx.ShortString(), Valid: err == nil})

@lrettig lrettig added the API label Aug 11, 2020
@lrettig lrettig self-assigned this Aug 11, 2020
@lrettig lrettig added this to To do in API Aug 11, 2020
lrettig added a commit that referenced this issue Aug 11, 2020
@lrettig
One more for the refactor
5108f75 
Fix #2116
@lrettig
Copy link
Member Author

lrettig commented Aug 11, 2020

Fixed by 5108f75

@lrettig lrettig mentioned this issue Aug 11, 2020
Closed
@lrettig lrettig moved this from To do to Review in API Aug 11, 2020
@lrettig lrettig moved this from Review to Done in API Aug 11, 2020
@bors bors bot closed this as completed in ce9d5da Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrettig lrettig

Labels
None yet
Projects
No open projects
API
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - API phase 9: finish implementing grpc services spacemeshos/go-spacemesh
1 participant
@lrettig