Gossip protocol validation #496
Conversation
…node.Node as sender
log/log.go
Outdated
| @@ -19,7 +19,7 @@ type Log struct { | |||
|
|
|||
| // smlogger is the local app singleton logger. | |||
| var AppLog Log | |||
| var debugMode = false | |||
| var debugMode = true | |||
p2p/gossip/protocol.go
Outdated
| prot.oldMessageMu.RLock() | ||
| res, ok := prot.invalidMessageQ[h] | ||
| prot.oldMessageMu.RUnlock() | ||
| if ok { |
There was a problem hiding this comment.
imo this looks better :
| if ok { | |
| if !ok { | |
| return Unknown | |
| } | |
| if !res { | |
| return Invalid | |
| } | |
| return Valid |
hare/messagevalidation.go
Outdated
| return true | ||
| } | ||
|
|
||
|
|
||
| func (validator *MessageValidator) ValidateMessage(m *pb.HareMessage, k uint32) bool { |
There was a problem hiding this comment.
used only in tests. maybe not needed anymore ?
There was a problem hiding this comment.
True - adjusted the test and removed the method
| Unknown | ||
| ) | ||
|
|
||
| func (prot *Protocol) isMessageValid(h hash) Validity { |
There was a problem hiding this comment.
IsMessageValid feels like it returns a bool, consider better naming
| close(c) | ||
| } | ||
| delete(sn.sim.protocolHandler, sn.Node.PublicKey().String()) | ||
| delete(sn.sim.protocolDirectHandler, sn.Node.PublicKey().String()) |
There was a problem hiding this comment.
should be doing the same for protocolGossipHandler now..
p2p/swarm.go
Outdated
|
|
||
| func (pm gossipProtocolMessage) ReportValidation(protocol string, isValid bool) { | ||
| if pm.validationChan != nil { | ||
| pm.validationChan <- *service.NewMessageValidation(pm.Bytes(), protocol, isValid) |
There was a problem hiding this comment.
fixed (see comment below)
p2p/service/service.go
Outdated
| } | ||
|
|
||
| func NewMessageValidation(msg []byte, prot string, isValid bool) *MessageValidation { | ||
| return &MessageValidation{msg, prot, isValid} |
There was a problem hiding this comment.
you dereference that everywhere, why don't just return it by value ?
There was a problem hiding this comment.
true, changed it to return a value
p2p/swarm.go
Outdated
|
|
||
| // RegisterGossipProtocol registers an handler for gossip based `protocol` | ||
| func (s *swarm) RegisterGossipProtocol(protocol string) chan service.GossipMessage { | ||
| mchan := make(chan service.GossipMessage, config.ConfigValues.BufferSize) |
There was a problem hiding this comment.
I know it was there already but it's better to take BufferSize from s.config.BufferSize. (where its loaded from config/flags)
hare/algorithm.go
Outdated
| // TODO: should return error from message validation to indicate what failed, should retry only for contextual failure | ||
| log.Warning("Message is not valid for either round") | ||
| log.Warning("DirectMessage is not valid for either round") |
There was a problem hiding this comment.
DirectMessage? I believe it happened during refactoring.
There was a problem hiding this comment.
I believe you believe correctly
hare/broker.go
Outdated
| } | ||
|
|
||
| func (msg Message) reportValidationResult(isValid bool) { | ||
| msg.validationChan <- *service.NewMessageValidation(msg.bytes, ProtoName, isValid) |
There was a problem hiding this comment.
Pass a pointer to the channel and don't deref.
To my understanding, it has no perf implications in this context. We can further discuss it if you like.
There was a problem hiding this comment.
msg.validationChan can be nil. nil will block.
hare/messagevalidation.go
Outdated
| return true | ||
| } | ||
|
|
||
|
|
||
| func (validator *MessageValidator) ValidateMessage(m *pb.HareMessage, k uint32) bool { |
There was a problem hiding this comment.
Remove. ValidateMessage is only used in the unit tests.
No description provided.