[backport] p2p: use decaying tags for fetch peers (#5564) #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's some peer churn (connection manager enabled, which is the default), fetch can be interrupted by connection manager dropping connections which are currently used for fetching. This can happen both for fetch clients and servers, breaking sync.
dshulyak
approved these changes
Feb 14, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v1.3 #5568 +/- ##
=======================================
- Coverage 77.3% 77.3% -0.1%
=======================================
Files 261 261
Lines 30891 30919 +28
=======================================
+ Hits 23903 23923 +20
- Misses 5488 5493 +5
- Partials 1500 1503 +3 ☔ View full report in Codecov by Sentry. |
|
bors merge |
|
This PR was included in a batch that successfully built, but then failed to merge into v1.3. It will not be retried. Additional information: Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
|
bors cancel |
|
Canceled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Backport #5564
Description
Use decaying tags for fetch peers